From: Junio C Hamano <gitster@pobox•com>
To: Michael J Gruber <git@drmicha•warpmail.net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH/WIP 0/6] Detached HEADs in new worktrees considered harmful
Date: Fri, 26 Feb 2016 09:37:24 -0800 [thread overview]
Message-ID: <xmqq60xbl6ej.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <cover.1456504190.git.git@drmicha.warpmail.net> (Michael J. Gruber's message of "Fri, 26 Feb 2016 17:39:40 +0100")
Michael J Gruber <git@drmicha•warpmail.net> writes:
> Before someone loses their HEAD I should put this series out (again).
>
> 1/6 is a tiny documentation fix.
>
> 2/6 demonstrates that "git prune" in the main worktree loses HEADs in other
> worktrees, and vice versa.
You do need to teach the reachability code to consider points that
are outside refs/ (HEAD and index, at least; I also recall there
were talks about per-worktree hierarchies in refs/?) as anchoring
objects to the non-prunable part of the history.
The prune/fsck reachability code already knows to consider objects
that are reachable only from the index as reachable, and I do not
think "rev-list --all" is used to enumerate them for safekeeping
(even when the worktree feature is not used). The reachability code
that enumerates objects in the index and cache-tree needs to learn
to peek into sibling worktrees' private objects, I would think, and
I do not think the addition is a good match for rev-list.
prev parent reply other threads:[~2016-02-26 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 16:39 [PATCH/WIP 0/6] Detached HEADs in new worktrees considered harmful Michael J Gruber
2016-02-26 16:39 ` [PATCH 1/6] Documentation/git-worktree: spell --detach correctly Michael J Gruber
2016-02-26 17:52 ` Junio C Hamano
2016-02-26 16:39 ` [PATCH 2/6] t6014: test prune with detached HEADs in separate worktrees Michael J Gruber
2016-02-26 18:03 ` Junio C Hamano
2016-02-26 16:39 ` [PATCH/RFD 3/6] rev-list: list all heads with --all Michael J Gruber
2016-02-27 2:15 ` Duy Nguyen
2016-02-26 16:39 ` [PATCH 4/6] WIP: mess only with mark_reachable Michael J Gruber
2016-02-26 16:39 ` [PATCH 5/6] WIP: fix unborn branch case Michael J Gruber
2016-02-26 16:39 ` [PATCH 6/6] revisions: list all worktree HEADs with --all Michael J Gruber
2016-02-26 17:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60xbl6ej.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox