From: Junio C Hamano <gitster@pobox•com>
To: Victor Leschuk <vleschuk@gmail•com>
Cc: git@vger•kernel.org, vleschuk@accesssoftek•com, normalperson@yhbt•net
Subject: Re: [PATCH v4] git-svn: add support for prefixed globs in config
Date: Wed, 30 Dec 2015 13:37:32 -0800 [thread overview]
Message-ID: <xmqq60zfehyb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1451470149-14735-1-git-send-email-vleschuk@accesssoftek.com> (Victor Leschuk's message of "Wed, 30 Dec 2015 13:09:09 +0300")
Victor Leschuk <vleschuk@gmail•com> writes:
> Introduce prefixed globs for branches and tags in git-svn.
> Globs like 'release_*' allow users to avoid long lines in config like:
>
> branches = branches/{release_20,release_21,release_22,...}
>
> Signed-off-by: Victor Leschuk <vleschuk@accesssoftek•com>
> ---
> Changes from v3:
> * Wrapped all test preparations in separate test-cases
>
> Documentation/git-svn.txt | 5 ++
> perl/Git/SVN/GlobSpec.pm | 9 ++-
> t/t9168-git-svn-prefixed-glob.sh | 142 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 151 insertions(+), 5 deletions(-)
> create mode 100755 t/t9168-git-svn-prefixed-glob.sh
>
> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
> index 0c0f60b..529cffe 100644
> --- a/Documentation/git-svn.txt
> +++ b/Documentation/git-svn.txt
> @@ -1034,6 +1034,7 @@ listed below are allowed:
> url = http://server.org/svn
> fetch = trunk/project-a:refs/remotes/project-a/trunk
> branches = branches/*/project-a:refs/remotes/project-a/branches/*
> + branches = branches/release_*:refs/remotes/project-a/branches/release_*
Hmph, if you are going this route, I wonder if there is a reason to
limit yourself only to "prefix". Would allowing something like this:
branches = branches/pre*post:refs/remotes/project-a/branches/*
i.e., loosening the rule to allow at most one asterisk anywhere on
the left hand side of the colon, and require the same number of
asterisks as the left hand side has on the right hand side of the
colon, be too lax and hurt the users?
next prev parent reply other threads:[~2015-12-30 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 10:09 [PATCH v4] git-svn: add support for prefixed globs in config Victor Leschuk
2015-12-30 21:37 ` Junio C Hamano [this message]
2016-01-05 8:15 ` Eric Wong
2016-01-10 11:00 ` Victor Leschuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60zfehyb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=normalperson@yhbt$(echo .)net \
--cc=vleschuk@accesssoftek$(echo .)com \
--cc=vleschuk@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox