From: Junio C Hamano <gitster@pobox•com>
To: Alexander 'z33ky' Hirsch <1zeeky@gmail•com>
Cc: git@vger•kernel.org, "brian m. carlson" <sandals@crustytoothpaste•net>
Subject: Re: [PATCH] rebase: add --verify-signatures
Date: Thu, 17 Dec 2015 10:22:20 -0800 [thread overview]
Message-ID: <xmqq60zxc4v7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20151217010422.GA19500@blarch> (Alexander Hirsch's message of "Thu, 17 Dec 2015 02:04:22 +0100")
Alexander 'z33ky' Hirsch <1zeeky@gmail•com> writes:
> As I understand it, this is the same reason for the existence of
> --verify-signatures for git-merge. Otherwise the same argument could be
> made for git-merge
I suspect that you are missing the bigger workflow issues, if you
think this and merge are the same.
git-merge will check the other history on the side branch that you
are merging _into_ the trunk, to give you an opportunity to reject
what does not pass and keep the trunk sane without doing anything
else. How you (or others who asked you to pull) clean up the side
branch is outside the scope of its verification.
Your change to "git pull --rebase" checks the other way---the
history, which is already the trunk, onto which your work will be
rebased. There is nothing you can do without messing with the trunk
if the validation did not pass, be it with a rewind-and-rebuild or a
sealing empty commit which is pointless.
next prev parent reply other threads:[~2015-12-17 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 13:03 [PATCH] rebase: add --verify-signatures Alexander 'z33ky' Hirsch
2015-12-10 19:11 ` Junio C Hamano
2015-12-10 19:53 ` Junio C Hamano
2015-12-16 13:39 ` Alexander 'z33ky' Hirsch
2015-12-16 18:12 ` Junio C Hamano
2015-12-17 1:04 ` Alexander 'z33ky' Hirsch
2015-12-17 18:22 ` Junio C Hamano [this message]
[not found] ` <20151221140414.GA3422@netblarch.tu-darmstadt.de>
[not found] ` <xmqqvb7re55d.fsf@gitster.mtv.corp.google.com>
2015-12-22 23:12 ` Alexander 'z33ky' Hirsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60zxc4v7.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=1zeeky@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox