public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Lars Schneider <larsxschneider@gmail•com>
Cc: git@vger•kernel.org, luke@diamand•org, tboegi@web•de
Subject: Re: [PATCH v3] git-p4: add "--path-encoding" option
Date: Tue, 01 Sep 2015 12:06:27 -0700	[thread overview]
Message-ID: <xmqq613urmbw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1243E147-EFEC-4D0B-9872-6B9A8BBE7737@gmail.com> (Lars Schneider's message of "Tue, 1 Sep 2015 20:55:13 +0200")

Lars Schneider <larsxschneider@gmail•com> writes:

> I searched the Internet for clues around cp1252 and found that a
> similar patch was submitted to Mercurial just a month ago. The author
> seconds my cp1252 observation:
> http://mercurial.808500.n3.nabble.com/PATCH-stable-convert-use-original-local-encoding-when-converting-from-Perfoce-tp4025088p4025094.html

Thanks for a pointer.  I see this bit in that thread:

     If P4CHARSET is not set explicitly when connecting to a Unicode
     mode server, a default charset will be chosen based on the
     client's platform and/or code page.

So I would guess that it is reproducible for you as you are always
on a client with the same platform and/or code page, and it would be
more honest to phrase it as "As an example, Perforce on my Windows
box uses..."  or something along that line.

Thanks.

  reply	other threads:[~2015-09-01 19:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 22:10 [PATCH v3] git-p4: add "--path-encoding" option larsxschneider
2015-08-31 22:10 ` larsxschneider
2015-08-31 23:13   ` Junio C Hamano
2015-09-01 13:42     ` Lars Schneider
2015-09-01 17:19       ` Junio C Hamano
2015-09-01 17:35       ` Junio C Hamano
2015-09-01 18:55         ` Lars Schneider
2015-09-01 19:06           ` Junio C Hamano [this message]
2015-09-01  4:37   ` Torsten Bögershausen
2015-09-01  7:14     ` Fwd: " Torsten Bögershausen
2015-09-01 12:47     ` Lars Schneider
2015-09-01 14:35       ` Torsten Bögershausen
2015-09-01 15:02         ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq613urmbw.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=larsxschneider@gmail$(echo .)com \
    --cc=luke@diamand$(echo .)org \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox