public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: peff@peff•net, git@vger•kernel.org
Subject: Re: [PATCH] p5310: Fix broken && chain in performance test
Date: Fri, 26 Jun 2015 15:27:20 -0700	[thread overview]
Message-ID: <xmqq616artpz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1435354020-11675-1-git-send-email-sbeller@google.com> (Stefan Beller's message of "Fri, 26 Jun 2015 14:27:00 -0700")

Stefan Beller <sbeller@google•com> writes:

> Signed-off-by: Stefan Beller <sbeller@google•com>

Thanks.  How did you find this (does the auto &&-chain test apply to
t/perf stuff as well)?

Will queue.

> ---
>  t/perf/p5310-pack-bitmaps.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/t/perf/p5310-pack-bitmaps.sh b/t/perf/p5310-pack-bitmaps.sh
> index f8ed857..de2a224 100755
> --- a/t/perf/p5310-pack-bitmaps.sh
> +++ b/t/perf/p5310-pack-bitmaps.sh
> @@ -39,14 +39,14 @@ test_expect_success 'create partial bitmap state' '
>  
>  	# now kill off all of the refs and pretend we had
>  	# just the one tip
> -	rm -rf .git/logs .git/refs/* .git/packed-refs
> -	git update-ref HEAD $cutoff
> +	rm -rf .git/logs .git/refs/* .git/packed-refs &&
> +	git update-ref HEAD $cutoff &&
>  
>  	# and then repack, which will leave us with a nice
>  	# big bitmap pack of the "old" history, and all of
>  	# the new history will be loose, as if it had been pushed
>  	# up incrementally and exploded via unpack-objects
> -	git repack -Ad
> +	git repack -Ad &&
>  
>  	# and now restore our original tip, as if the pushes
>  	# had happened

next prev parent reply	other threads:[~2015-06-26 22:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 21:27 [PATCH] p5310: Fix broken && chain in performance test Stefan Beller
2015-06-26 22:27 ` Junio C Hamano [this message]
2015-06-26 22:34   ` Stefan Beller
2015-06-27  6:14     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq616artpz.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=sbeller@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox