From: Junio C Hamano <gitster@pobox•com>
To: "SZEDER Gábor" <szeder@ira•uka.de>
Cc: Thomas Braun <thomas.braun@virtuell-zuhause•de>,
git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>,
John Keeping <john@keeping•me.uk>
Subject: Re: [PATCH v2 1/2] completion: Add sequencer function
Date: Mon, 01 Jun 2015 07:38:07 -0700 [thread overview]
Message-ID: <xmqq6177a3zk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150530210103.Horde.YoJthfdQJy5oq9wT_oOl3Q1@webmail.informatik.kit.edu> ("SZEDER Gábor"'s message of "Sat, 30 May 2015 21:01:03 +0200")
SZEDER Gábor <szeder@ira•uka.de> writes:
> I don't see the benefits of this change. This patch adds more than
> twice as many lines as it removes, and patch 2/2 adds 8 new lines
> although it could get away with only 5 without this function. To
> offer sequencer options we currently go through a single if statement,
> with this patch we'd go through a case statement, an if statement and
> finally an &&.
>
> Gábor
Perhaps, especially given that I'd imagine we won't be adding 47 new
commands that drive the sequencer in the near future ;-)
I presume that you are OK with Thomas's original version, then?
next prev parent reply other threads:[~2015-06-01 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 9:59 [PATCH] completion: suggest sequencer commands for revert Thomas Braun
2015-05-29 19:50 ` Junio C Hamano
2015-05-29 23:13 ` Ramkumar Ramachandra
2015-05-30 15:57 ` [PATCH v2 0/2] completion: sequencer commands Thomas Braun
2015-05-30 16:01 ` [PATCH v2 2/2] completion: suggest sequencer commands for revert Thomas Braun
2015-05-30 16:01 ` [PATCH v2 1/2] completion: Add sequencer function Thomas Braun
2015-05-30 19:01 ` SZEDER Gábor
2015-06-01 14:38 ` Junio C Hamano [this message]
2015-06-01 15:06 ` SZEDER Gábor
2015-05-30 16:02 ` Thomas Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq6177a3zk.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=john@keeping$(echo .)me.uk \
--cc=szeder@ira$(echo .)uka.de \
--cc=thomas.braun@virtuell-zuhause$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox