public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Vitor Antunes <vitor.hda@gmail•com>
Cc: Pete Wyckoff <pw@padd•com>,
	git@vger•kernel.org, Karsten Blees <karsten.blees@gmail•com>
Subject: Re: [PATCH 2/2] git-p4: Fix copy detection test
Date: Sat, 28 Mar 2015 09:12:59 -0700	[thread overview]
Message-ID: <xmqq619lyub8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150328003636.07930f83@pt-vhugo> (Vitor Antunes's message of "Sat, 28 Mar 2015 00:36:36 +0000")

Vitor Antunes <vitor.hda@gmail•com> writes:

> Vitor Antunes <vitor.hda@gmail•com> wrote:
>
>>Junio C Hamano <gitster@pobox•com> wrote:
>>>Pete, these tests blame to your 9b6513ac (git p4 test: split up big
>>>t9800 test, 2012-06-27).  I presume that you tested the result of
>>>this splitting, but do you happen to know if we did something to
>>>cause the test to break recently?
>>
>>I also worked on these tests at that time and they were passing before and
>>after the reorganization. I'll prepare a bisect script and will try to find the
>>commit that started making this test fail.
>
> According to bisect, this is the first commit that makes the test fail:
>
> 7c85f8acb2282e3ed108c46b59fd5daa78bf17db
>
> Does this make sense to you?

Yeah, as the blamed commit changes the way the hashtable is used
record and choose the rename source candidates, it is not surprising
if it changes how two or more candidates with the same rename score
are tie-broken.

Thanks.

next prev parent reply	other threads:[~2015-03-28 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27  1:04 [PATCH 0/2] git-p4: Small updates to test cases Vitor Antunes
2015-03-27  1:04 ` [PATCH 1/2] git-p4: Make rename test case runnable under dash Vitor Antunes
2015-03-27  1:04 ` [PATCH 2/2] git-p4: Fix copy detection test Vitor Antunes
2015-03-27 22:23   ` Junio C Hamano
2015-03-27 23:59     ` Vitor Antunes
2015-03-28  0:36       ` Vitor Antunes
2015-03-28 16:12         ` Junio C Hamano [this message]
2015-03-27  1:26 ` [PATCH 0/2] git-p4: Small updates to test cases Junio C Hamano
2015-03-27  1:45   ` Junio C Hamano
2015-03-27  1:54   ` Vitor Antunes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq619lyub8.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=karsten.blees@gmail$(echo .)com \
    --cc=pw@padd$(echo .)com \
    --cc=vitor.hda@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox