From: Junio C Hamano <gitster@pobox•com>
To: Johan Herland <johan@herland•net>
Cc: git@vger•kernel.org, mackyle@gmail•com, jhf@trifork•com,
Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCHv3 2/5] t3301: Verify that 'git notes' removes empty notes by default
Date: Fri, 07 Nov 2014 09:48:00 -0800 [thread overview]
Message-ID: <xmqq61eqhpgv.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1415351961-31567-3-git-send-email-johan@herland.net> (Johan Herland's message of "Fri, 7 Nov 2014 10:19:18 +0100")
Johan Herland <johan@herland•net> writes:
> Add test cases documenting the current behavior when trying to
> add/append/edit empty notes. This is in preparation for adding
> --allow-empty; to allow empty notes to be stored.
>
> Improved-by: Eric Sunshine <sunshine@sunshineco•com>
> Improved-by: Junio C Hamano <gitster@pobox•com>
> Signed-off-by: Johan Herland <johan@herland•net>
> ---
> t/t3301-notes.sh | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
> index cfd67ff..33f0558 100755
> --- a/t/t3301-notes.sh
> +++ b/t/t3301-notes.sh
> @@ -1239,4 +1239,31 @@ test_expect_success 'git notes get-ref (--ref)' '
> test "$(GIT_NOTES_REF=refs/notes/bar git notes --ref=baz get-ref)" = "refs/notes/baz"
> '
>
> +test_expect_success 'setup testing of empty notes' '
> + git config --unset core.notesRef &&
Use "test_unconfig" instead?
If the previous test failed (or a different topic that touches this
same script is merged to change what the previous test leaves), this
configuration variable may not be set, and "config --unset" may
fail.
> + test_commit 16th &&
> + empty_blob=$(git hash-object -w /dev/null)
> +'
> +
> +while read cmd
> +do
> + test_expect_success "'git notes $cmd' removes empty note" "
> + test_might_fail git notes remove HEAD &&
> + MSG= git notes $cmd &&
> + test_must_fail git notes list HEAD
> + "
> +done <<\EOF
> +add
> +add -F /dev/null
> +add -m ""
> +add -c "$empty_blob"
> +add -C "$empty_blob"
> +append
> +append -F /dev/null
> +append -m ""
> +append -c "$empty_blob"
> +append -C "$empty_blob"
> +edit
> +EOF
> +
> test_done
next prev parent reply other threads:[~2014-11-07 17:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 9:19 [PATCHv3 0/5] Handling empty notes Johan Herland
2014-11-07 9:19 ` [PATCHv3 1/5] builtin/notes: Fix premature failure when trying to add the empty blob Johan Herland
2014-11-07 9:19 ` [PATCHv3 2/5] t3301: Verify that 'git notes' removes empty notes by default Johan Herland
2014-11-07 17:48 ` Junio C Hamano [this message]
2014-11-07 9:19 ` [PATCHv3 3/5] builtin/notes: Add --allow-empty, to allow storing empty notes Johan Herland
2014-11-07 18:04 ` Junio C Hamano
2014-11-09 12:31 ` Johan Herland
2014-11-10 20:18 ` Junio C Hamano
2014-11-07 9:19 ` [PATCHv3 4/5] notes: Empty notes should be shown by 'git log' Johan Herland
2014-11-07 18:51 ` Junio C Hamano
2014-11-07 9:19 ` [PATCHv3 5/5] t3301: Use write_script(), nitpick whitespace Johan Herland
2014-11-07 18:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61eqhpgv.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jhf@trifork$(echo .)com \
--cc=johan@herland$(echo .)net \
--cc=mackyle@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox