From: Junio C Hamano <gitster@pobox•com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] compat-util: add _DEFAULT_SOURCE define
Date: Mon, 15 Sep 2014 12:02:33 -0700 [thread overview]
Message-ID: <xmqq61go7lme.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1410672815-2555-1-git-send-email-sergey.senozhatsky@gmail.com> (Sergey Senozhatsky's message of "Sun, 14 Sep 2014 14:33:35 +0900")
Sergey Senozhatsky <sergey.senozhatsky@gmail•com> writes:
> glibc has deprecated the use of _BSD_SOURCE define
>
> warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
>
> To make it easier to maintain a cross platform source code, that
> warning can be suppressed by _DEFAULT_SOURCE.
>
> Define both _BSD_SOURCE, _DEFAULT_SOURCE and cleanup the build.
I can see you defined DEFAULT_SOURCE, but where did you do "cleanup
the build"? Or did you mean "define both (in order) to clean up"?
Just making sure we are not only seeing a patch half eaten by mail
transport somewhere.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail•com>
> ---
> git-compat-util.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 4e7e3f8..08a9ee2 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -82,6 +82,7 @@
> #define _ALL_SOURCE 1
> #define _GNU_SOURCE 1
> #define _BSD_SOURCE 1
> +#define _DEFAULT_SOURCE 1
> #define _NETBSD_SOURCE 1
> #define _SGI_SOURCE 1
next prev parent reply other threads:[~2014-09-15 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 5:33 [PATCH] compat-util: add _DEFAULT_SOURCE define Sergey Senozhatsky
2014-09-15 19:02 ` Junio C Hamano [this message]
2014-09-17 3:54 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61go7lme.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sergey.senozhatsky@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox