Subject: Re: [PATCH v3 1/2] Push the NATIVE_CRLF Makefile variable to C and added a test for native.

From: Junio C Hamano <[email-masked]>
Date: Tue, 02 Sep 2014 12:03:05 -0700

Torsten Bögershausen <[email-masked]> writes:

> From: Pat Thoyts <[email-masked]>
>
> Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
> incorrectly set on Mingw git. However, the Makefile variable is not
> propagated to the C preprocessor and results in no change. This patch
> pushes the definition to the C code and adds a test to validate that
> when core.eol as native is crlf, we actually normalize text files to this
> line ending convention when core.autocrlf is false.
>
> Signed-off-by: Pat Thoyts <[email-masked]>
> Signed-off-by: Stepan Kasal <[email-masked]>
> Signed-off-by: Torsten Bögershausen <[email-masked]>
> ---
> This mini series mainly updates git.git with patches from msysgit:
> Patch 1 is taken "as is",
> Patch 2 is taken from msysgit "nearly as is": the broken && chain
> had been fixed.

Shouldn't Patch 1 also be made "nearly as is" to fix the same?