public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Jacob Keller <jacob.e.keller@intel•com>
Cc: git@vger•kernel.org, Jonas 'Sortie' Termansen <sortie@maxsi•org>
Subject: Re: [PATCH 9/9] Use timer_settime for new platforms
Date: Fri, 29 Aug 2014 11:12:25 -0700	[thread overview]
Message-ID: <xmqq61hb6u7q.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1409330561-11806-9-git-send-email-jacob.e.keller@intel.com> (Jacob Keller's message of "Fri, 29 Aug 2014 09:42:41 -0700")

Jacob Keller <jacob.e.keller@intel•com> writes:

> diff --git a/builtin/log.c b/builtin/log.c
> index 4389722b4b1e..a39e82d67eb3 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> ...
> @@ -271,9 +271,12 @@ static void log_show_early(struct rev_info *revs, struct commit_list *list)
>  	 * trigger every second even if we're blocked on a
>  	 * reader!
>  	 */
> -	early_output_timer.it_value.tv_sec = 0;
> -	early_output_timer.it_value.tv_usec = 500000;
> -	setitimer(ITIMER_REAL, &early_output_timer, NULL);
> +	struct itimerspec value;
> +	value.it_value.tv_sec = 0;
> +	value.it_value.tv_nsec = 500000L * 1000L;
> +	value.it_interval.tv_sec = 0;
> +	value.it_interval.tv_nsec = 0;
> +	timer_settime(early_output_timer, 0, &value, NULL);

Do I see decl-after-stmt up there?

  parent reply	other threads:[~2014-08-29 18:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 16:42 [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval Jacob Keller
2014-08-29 16:42 ` [PATCH 2/9] autoconf: Check for " Jacob Keller
2014-08-29 16:42 ` [PATCH 3/9] autoconf: Check for setitimer Jacob Keller
2014-08-29 16:42 ` [PATCH 4/9] autoconf: Check for timer_t Jacob Keller
2014-08-29 18:20   ` Jonas 'Sortie' Termansen
2014-08-29 16:42 ` [PATCH 5/9] autoconf: Check for struct timespec Jacob Keller
2014-08-29 16:42 ` [PATCH 6/9] autoconf: Check for struct sigevent Jacob Keller
2014-08-29 16:42 ` [PATCH 7/9] autoconf: Check for struct itimerspec Jacob Keller
2014-08-29 16:42 ` [PATCH 8/9] autoconf: Check for timer_settime Jacob Keller
2014-08-29 17:26   ` Johannes Sixt
2014-08-29 17:40     ` Keller, Jacob E
2014-09-10 15:33       ` Karsten Blees
2014-09-10 21:08         ` Junio C Hamano
2014-09-10 21:13           ` Keller, Jacob E
2014-08-29 16:42 ` [PATCH 9/9] Use timer_settime for new platforms Jacob Keller
2014-08-29 18:02   ` Junio C Hamano
2014-08-29 18:09     ` Keller, Jacob E
2014-08-29 18:12   ` Junio C Hamano [this message]
2014-08-29 16:48 ` [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval Keller, Jacob E
2014-08-29 18:54   ` Jonas 'Sortie' Termansen
2014-08-29 19:07     ` Junio C Hamano
2014-08-29 19:43       ` Jonas 'Sortie' Termansen
2014-09-03  0:17         ` Keller, Jacob E
  -- strict thread matches above, loose matches on Subject: below --
2014-08-28  1:04 [PATCH 0/9] Use timer_settime for new platforms Jonas 'Sortie' Termansen
2014-08-28  1:04 ` [PATCH 9/9] " Jonas 'Sortie' Termansen
2014-08-28 19:43   ` Junio C Hamano
2014-08-29 16:11     ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq61hb6u7q.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jacob.e.keller@intel$(echo .)com \
    --cc=sortie@maxsi$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox