From: Junio C Hamano <gitster@pobox•com>
To: David Turner <dturner@twopensource•com>
Cc: git@vger•kernel.org, David Turner <dturner@twitter•com>
Subject: Re: [PATCH] receive-pack: optionally deny case-clone refs
Date: Tue, 03 Jun 2014 15:13:31 -0700 [thread overview]
Message-ID: <xmqq61khwsj8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1401832959.18134.120.camel@stross> (David Turner's message of "Tue, 03 Jun 2014 18:02:39 -0400")
David Turner <dturner@twopensource•com> writes:
> I would be happy to add "case-clone" to the glossary -- would that be OK
> with you? I do not immediately think of the better term.
Somehow "case-clone" sounds strange, though X-<.
>> (Mental note to the reviewer himself) This returns true iff there is
>> an existing ref whose name is only different in case, and cause
>> for-each-ref to return early with true. In a sane case of not
>> receiving problematic refs, this will have to iterate over all the
>> existing refnames. Wonder if there are better ways to optimize this
>> in a repository with hundreds or thousands of refs, which is not all
>> that uncommon.
>
> My expectation is that on average a push will involve a small number of
> refs -- usually exactly one.
It does not matter that _you_ push only one, because the number of
existing refs at the receiving end is what determines how many times
the for-each-ref loop spins, no?
> Yes, but it's harder to test on case-insensitive filesystems because we
> cannot have coexisting local case-clone branches.
You do not have to (and you should not) do "git checkout -b" to
create various local branches in the first place. For example:
git send-pack ./victim HEAD^1:refs/heads/caseclone &&
test_must_fail git send-pack ./victim HEAD:refs/heads/CaseClone
would let you push the parent of the current tip to caseclone and
then attempt to push the current tip to CaseClone. If the receiving
end could incorrectly fast-forwards caseclone, you found a bug ;-)
next prev parent reply other threads:[~2014-06-03 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 19:14 [PATCH] receive-pack: optionally deny case-clone refs David Turner
2014-06-03 21:33 ` Junio C Hamano
2014-06-03 22:02 ` David Turner
2014-06-03 22:13 ` Junio C Hamano [this message]
2014-06-04 3:05 ` David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61khwsj8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dturner@twitter$(echo .)com \
--cc=dturner@twopensource$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox