public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: "Torsten Bögershausen" <tboegi@web•de>, git@vger•kernel.org
Subject: Re: [PATCH] Unicode: update of combining code points
Date: Tue, 08 Apr 2014 15:37:15 -0700	[thread overview]
Message-ID: <xmqq61mj30tg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140407195458.GA3912@google.com> (Jonathan Nieder's message of "Mon, 7 Apr 2014 12:54:58 -0700")

Jonathan Nieder <jrnieder@gmail•com> writes:

> Torsten Bögershausen wrote:
>
>> Unicode 6.3 defines the following code as combining or accents,
>> git_wcwidth() should return 0.
>>
>> Earlier unicode standards had defined these code point as "reserved":
>
> Thanks for the update.  Could the commit message also explain how this
> was noticed and what the user-visible effect is?
>
> For example:
>
>  "Unicode just announced that <...>.  That means we should mark the
>   relevant code points as combining characters so git knows they are
>   zero-width and doesn't screw up the alignment when presenting branch
>   names in columns with 'git branch --column'"
>
> or something like that.

Perhaps (the original read clearly enough for me, though).

> [...]
>> 358 COMBINING DOT ABOVE RIGHT
>> 359 COMBINING ASTERISK BELOW
>
> I'm not sure this list is needed --- the code + the reference to the
> Unicode 6.3 standard seems like enough (but if you think otherwise,
> I don't really mind).

I can go either way.

>> This commit touches only the range 300-6FF, there may be more to be updated.
>
> The "there may be more" here sounds ominous.

Indeed it does ;-)

> Does that mean Unicode
> 6.3 also added some zero-width characters in other ranges that should
> be dealt with in the future?  How many such ranges?  How do we know
> when we're done?
>
> Just biting off the most important characters first and putting off
> the rest for later sounds fine to me --- my complaint is that the
> above comment doesn't make clear what the to-do list is for finishing
> the update later.

I'll queue this at the tip of 'pu', not to forget about it while
waiting for a clarification.

Thanks.

next prev parent reply	other threads:[~2014-04-08 22:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 19:39 [PATCH] Unicode: update of combining code points Torsten Bögershausen
2014-04-07 19:54 ` Jonathan Nieder
2014-04-08 22:37   ` Junio C Hamano [this message]
2014-04-09 16:48     ` Torsten Bögershausen
2014-04-09 17:30       ` Junio C Hamano
2014-04-10  4:12         ` Torsten Bögershausen
  -- strict thread matches above, loose matches on Subject: below --
2014-04-07 19:38 Torsten Bögershausen
2014-04-07 19:34 Torsten Bögershausen
2014-04-07 19:30 Torsten Bögershausen
2014-04-15 19:10 ` Peter Krefting
2014-04-16  4:48   ` Torsten Bögershausen
2014-04-16 10:51     ` Kevin Bracey
2014-04-16 19:58       ` Torsten Bögershausen
2014-04-17  6:32         ` Kevin Bracey
2014-04-24  9:02     ` Peter Krefting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq61mj30tg.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jrnieder@gmail$(echo .)com \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox