From: Junio C Hamano <gitster@pobox•com>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2 2/2] test/send-email: add to-cover test
Date: Thu, 03 Apr 2014 11:44:29 -0700 [thread overview]
Message-ID: <xmqq61mqqmlu.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1396548814-27278-2-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 3 Apr 2014 21:14:11 +0300")
"Michael S. Tsirkin" <mst@redhat•com> writes:
> Does it work? I am not sure.
Then why was it sent here?
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 3119c8c..3b17884 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -1334,6 +1334,22 @@ test_expect_success $PREREQ '--force sends cover letter template anyway' '
> test -n "$(ls msgtxt*)"
> '
>
> +test_expect_success $PREREQ 'to-cover adds To to all mail' '
> + clean_fake_sendmail &&
> + rm -fr outdir &&
> + git format-patch --cover-letter -2 -o outdir &&
> + git send-email \
> + --force \
> + --from="Example <nobody@example•com>" \
> + --to=nobody@example•com \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + outdir/0002-*.patch \
> + outdir/0000-*.patch \
> + outdir/0001-*.patch \
> + 2>errors >out &&
> + ! grep "SUBJECT HERE" errors &&
> + test -n "$(ls msgtxt*)"
> +'
Is this a copy of an existing "--force can disable the safety to
catch a mistake to send a cover letter template without any update"?
How are you checking if you are propagating to/cc from the cover to
other messages with this test?
Puzzled.
next prev parent reply other threads:[~2014-04-03 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 18:14 [PATCH v2 1/2] git-send-email: two new options: to-cover, cc-cover Michael S. Tsirkin
2014-04-03 18:14 ` [PATCH v2 2/2] test/send-email: add to-cover test Michael S. Tsirkin
2014-04-03 18:44 ` Junio C Hamano [this message]
2014-04-03 18:31 ` [PATCH v2 1/2] git-send-email: two new options: to-cover, cc-cover Junio C Hamano
2014-04-27 18:36 ` Michael S. Tsirkin
2014-04-03 21:24 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61mqqmlu.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox