From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Uwe Storbeck <uwe@ibr•ch>, git@vger•kernel.org
Subject: Re: [PATCH] test-lib.sh: use printf instead of echo
Date: Mon, 17 Mar 2014 12:26:42 -0700 [thread overview]
Message-ID: <xmqq61nceidp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140315001855.GK15625@google.com> (Jonathan Nieder's message of "Fri, 14 Mar 2014 17:18:55 -0700")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Uwe Storbeck wrote:
>
>> Backslash sequences are interpreted as control characters
>> by the echo command of some shells (e.g. dash).
>
> This has bothered me for a while but never enough to do anything about
> it. Thanks for fixing it.
>
>> Signed-off-by: Uwe Storbeck <uwe@ibr•ch>
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail•com>
>
> (patch left unsnipped for reference)
>> ---
>> t/test-lib.sh | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index 1531c24..8209204 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -277,7 +277,7 @@ error "Test script did not set test_description."
>>
>> if test "$help" = "t"
>> then
>> - echo "$test_description"
>> + printf '%s\n' "$test_description"
>> exit 0
>> fi
>>
>> @@ -328,7 +328,7 @@ test_failure_ () {
>> test_failure=$(($test_failure + 1))
>> say_color error "not ok $test_count - $1"
>> shift
>> - echo "$@" | sed -e 's/^/# /'
>> + printf '%s\n' "$@" | sed -e 's/^/# /'
This is wrong, isn't it? Why do we want one line per item here?
>> test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; }
>> }
>>
next prev parent reply other threads:[~2014-03-17 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 23:57 [PATCH] test-lib.sh: use printf instead of echo Uwe Storbeck
2014-03-15 0:18 ` Jonathan Nieder
2014-03-17 19:26 ` Junio C Hamano [this message]
2014-03-18 22:18 ` Jonathan Nieder
2014-03-19 17:17 ` Junio C Hamano
2014-03-19 17:22 ` David Kastrup
2014-03-19 19:24 ` Junio C Hamano
2014-03-20 0:17 ` Jonathan Nieder
2014-03-20 16:42 ` Junio C Hamano
2014-03-15 8:59 ` Johannes Sixt
2014-03-17 18:38 ` Uwe Storbeck
2014-03-17 18:39 ` [PATCH v2] " Uwe Storbeck
2014-03-18 0:14 ` [PATCH v3] test-lib.sh: do not "echo" externally supplied strings Uwe Storbeck
2014-03-18 18:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61nceidp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=uwe@ibr$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox