From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Guanglin Xu <mzguanglin@gmail•com>, Git List <git@vger•kernel.org>
Subject: Re: [PATCH v2] branch.c: change install_branch_config() to use skip_prefix()
Date: Mon, 03 Mar 2014 10:49:27 -0800 [thread overview]
Message-ID: <xmqq61nvqfrc.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cRy2Jt_3DAS=ARzN-8HT3rdMCSGP5QfU8sJZGwqsJTG3g@mail.gmail.com> (Eric Sunshine's message of "Sun, 2 Mar 2014 17:56:09 -0500")
Eric Sunshine <sunshine@sunshineco•com> writes:
>> diff --git a/branch.c b/branch.c
>> index 723a36b..ca4e824 100644
>> --- a/branch.c
>> +++ b/branch.c
>> @@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin)
>> void install_branch_config(int flag, const char *local, const char *origin, const char *remote)
>> {
>> const char *shortname = remote + 11;
>> - int remote_is_branch = starts_with(remote, "refs/heads/");
>> + int remote_is_branch = (NULL != skip_prefix(remote ,"refs/heads/"));
>
> This actually makes the code more difficult to read and understand.
> There's a more fundamental reason to use skip_prefix() here. See if
> you can figure it out. (Hint: shortname)
I've already queued 0630aa49 (branch: use skip_prefix() in
install_branch_config(), 2014-02-28) on this topic, by the way.
prev parent reply other threads:[~2014-03-03 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 15:55 [PATCH v2] branch.c: change install_branch_config() to use skip_prefix() Guanglin Xu
2014-03-02 22:56 ` Eric Sunshine
2014-03-03 1:41 ` Guanglin Xu
2014-03-03 18:49 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61nvqfrc.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mzguanglin@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox