public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/2] t7700: do not use "touch -r"
Date: Thu, 23 Jan 2014 13:12:55 -0800	[thread overview]
Message-ID: <xmqq61patnag.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140123195518.GB31871@sigill.intra.peff.net> (Jeff King's message of "Thu, 23 Jan 2014 14:55:18 -0500")

Jeff King <peff@peff•net> writes:

> ... The test does not care about the timestamp of the
> .keep file it creates at all, only that it exists.

Please refrain from using "touch" for such use cases in the first
place.  It appears that

	>pack-$packsha1.keep &&

is what the test wants.

  reply	other threads:[~2014-01-23 21:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 19:54 [PATCH 0/2] solaris test fixups Jeff King
2014-01-23 19:54 ` [PATCH 1/2] t7501: fix "empty commit" test with NO_PERL Jeff King
2014-01-23 19:55 ` [PATCH 2/2] t7700: do not use "touch -r" Jeff King
2014-01-23 21:12   ` Junio C Hamano [this message]
2014-01-23 21:14     ` Jeff King
2014-01-23 21:24       ` Junio C Hamano
2014-01-23 21:28         ` Jeff King
2014-01-23 20:52 ` [PATCH 0/2] solaris test fixups Junio C Hamano
2014-01-23 20:54   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq61patnag.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox