From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCHv2] mailmap: handle mailmap blobs without trailing newlines
Date: Wed, 28 Aug 2013 12:39:00 -0700 [thread overview]
Message-ID: <xmqq61upa9m3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20130828014138.GA30623@sigill.intra.peff.net> (Jeff King's message of "Tue, 27 Aug 2013 21:41:39 -0400")
Jeff King <peff@peff•net> writes:
> This makes the code simpler and shorter (because we don't
> have to correlate strchrnul with the length calculation),
> correct (because the code with the off-by-one just goes
> away), and more efficient (we can drop the extra allocation
> we needed to create NUL-terminated strings for each line,
> and just terminate in place).
Nice. Will queue. Thanks.
prev parent reply other threads:[~2013-08-28 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 1:41 [PATCHv2] mailmap: handle mailmap blobs without trailing newlines Jeff King
2013-08-28 19:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61upa9m3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox