From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: git@vger•kernel.org, "SZEDER Gábor" <szeder.dev@gmail•com>,
"Hubert Jasudowicz" <hubertj@stmcyber•pl>,
"Derrick Stolee" <derrickstolee@github•com>
Subject: Re: [PATCH 0/2] builtin/bundle.c: segfault fix style & error reporting follow-up
Date: Wed, 28 Dec 2022 08:32:32 +0900 [thread overview]
Message-ID: <xmqq7cycqv73.fsf@gitster.g> (raw)
In-Reply-To: <cover-0.2-00000000000-20221227T183708Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 27 Dec 2022 19:39:08 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> Here's a couple of general improvements on top of ab/bundle-wo-args,
> we should also report to the user that they were missing the <file>
> argument, as 2/2 here fixes.
>
> Ævar Arnfjörð Bjarmason (2):
> builtin/bundle.c: remove superfluous "newargc" variable
> bundle <cmd>: have usage_msg_opt() note the missing "<file>"
>
> builtin/bundle.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
I have no strong opinions on the second one, but the first one is a
definite improvement. Will queue both. Thanks.
prev parent reply other threads:[~2022-12-27 23:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 12:31 [PATCH] Revert "builtin/bundle.c: let parse-options parse subcommands" Hubert Jasudowicz
2022-12-20 13:30 ` Derrick Stolee
2022-12-20 13:42 ` Ævar Arnfjörð Bjarmason
2022-12-20 13:40 ` [PATCH] bundle: don't segfault on "git bundle <subcmd>" Ævar Arnfjörð Bjarmason
2022-12-20 13:50 ` Hubert Jasudowicz
2022-12-25 11:06 ` Junio C Hamano
2022-12-25 11:05 ` Junio C Hamano
2022-12-27 18:39 ` [PATCH 0/2] builtin/bundle.c: segfault fix style & error reporting follow-up Ævar Arnfjörð Bjarmason
2022-12-27 18:39 ` [PATCH 1/2] builtin/bundle.c: remove superfluous "newargc" variable Ævar Arnfjörð Bjarmason
2022-12-27 18:39 ` [PATCH 2/2] bundle <cmd>: have usage_msg_opt() note the missing "<file>" Ævar Arnfjörð Bjarmason
2022-12-27 23:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7cycqv73.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=derrickstolee@github$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hubertj@stmcyber$(echo .)pl \
--cc=szeder.dev@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox