From: Junio C Hamano <gitster@pobox•com>
To: Antoine Tenart <antoine.tenart@ack•tf>
Cc: git@vger•kernel.org, pclouds@gmail•com, sunshine@sunshineco•com
Subject: Re: [PATCH] worktree: add: introduce the --name option
Date: Tue, 19 Jul 2016 11:04:59 -0700 [thread overview]
Message-ID: <xmqq7fchh5bo.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160719144701.571-1-antoine.tenart@ack.tf> (Antoine Tenart's message of "Tue, 19 Jul 2016 16:47:01 +0200")
Antoine Tenart <antoine.tenart@ack•tf> writes:
> Adds a --name option allowing to specify the name of a worktree when
> creating it. This allows to have multiple worktrees in directories
> having the same name (e.g. project0/foo, project1/foo etc...). This
> commit keeps the previous behaviour by making it the default value, i.e.
> by using $(basename <path>) as the worktree name when the --name option
> isn't used.
>
> Two new test cases are added to ensure the --name option does not break
> other functionalities and is working properly.
>
> Finally, the documentation is updated to reflect this --name option
> addition.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@ack•tf>
> ---
Hmm, is this related to an earlier discussion
https://public-inbox.org/git/20160625051548.95564-1-barret%40brennie.ca/
in any way, or is it an independent invention?
The conclusion of that discussion thread was roughly "users
shouldn't even _care_ about the name, and if they have to use name
to identify the worktrees to do certain things right now, reducing
the need for such 'certain things', not making it easy to give a
user-defined name to a worktree, is the way to go", IIRC.
next prev parent reply other threads:[~2016-07-19 18:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 14:47 [PATCH] worktree: add: introduce the --name option Antoine Tenart
2016-07-19 18:04 ` Junio C Hamano [this message]
2016-07-19 18:23 ` Duy Nguyen
2016-07-19 18:54 ` Antoine Tenart
2016-07-19 19:04 ` Duy Nguyen
2016-07-19 19:21 ` Eric Sunshine
2016-07-19 19:35 ` Antoine Tenart
2016-07-20 14:54 ` Duy Nguyen
2016-07-20 16:12 ` Antoine Tenart
2016-07-19 18:45 ` Antoine Tenart
2016-07-19 19:08 ` Junio C Hamano
2016-07-19 19:33 ` Antoine Tenart
2016-07-19 18:52 ` Eric Sunshine
2016-07-20 6:41 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fchh5bo.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=antoine.tenart@ack$(echo .)tf \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox