public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: Johannes Sixt <j6t@kdbg•org>,
	Alexander Rinass <alex@fournova•com>,
	git@vger•kernel.org
Subject: Re: [PATCH] diff: run arguments through precompose_argv
Date: Tue, 05 Apr 2016 14:42:23 -0700	[thread overview]
Message-ID: <xmqq7fgb20n4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <570411A6.6060208@web.de> ("Torsten Bögershausen"'s message of "Tue, 5 Apr 2016 21:27:34 +0200")

Torsten Bögershausen <tboegi@web•de> writes:

> On 05.04.16 21:15, Johannes Sixt wrote:
>> Am 05.04.2016 um 19:09 schrieb Junio C Hamano:
>>>> Thanks-to: Torsten Bögershausen <tboegi@web•de>
>> 
>> I sense NFD disease: The combining diaresis should combine with the o, not the g. Here is a correct line to copy-and-paste if you like:
>> 
>> Thanks-to: Torsten Bögershausen <tboegi@web•de>
>> 
>> -- Hannes
>
> Good eyes.
>
> And thanks to Alexander for doing this patch

Yup.  It is funny that I wrote:

    Thanks.  The log message talks about "such a file path", but
    precompose_argv() applies indiscriminately on any command line
    arguments, so things like -G<string> would also get the same
    treatment, which I think is what most users would want.

but "git log --grep=" with your name would not have found the one
that would have resulted from the original e-mail message applied.

next prev parent reply	other threads:[~2016-04-05 21:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 20:38 [PATCH] diff: run arguments through precompose_argv Alexander Rinass
2016-04-04 20:38 ` Alexander Rinass
2016-04-05 17:09   ` Junio C Hamano
2016-04-05 19:15     ` Johannes Sixt
2016-04-05 19:27       ` Torsten Bögershausen
2016-04-05 21:42         ` Junio C Hamano [this message]
2016-04-06  6:51       ` Alexander Rinass
2016-04-06  7:47         ` Torsten Bögershausen
2016-04-06 17:27           ` Junio C Hamano
2016-05-11 22:08         ` Junio C Hamano
2016-05-12 11:16           ` Alexander Rinass
2016-05-12 15:39             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7fgb20n4.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=alex@fournova$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=j6t@kdbg$(echo .)org \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox