From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org, "Stefan Näwe" <stefan.naewe@atlas-elektronik•com>
Subject: Re: [RFC/PATCH 0/3] silence missing-link warnings in some cases
Date: Mon, 01 Jun 2015 09:11:56 -0700 [thread overview]
Message-ID: <xmqq7frn8l2r.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150601154103.GA14538@peff.net> (Jeff King's message of "Mon, 1 Jun 2015 11:41:03 -0400")
Jeff King <peff@peff•net> writes:
>> The fixes make sense to me (I haven't carefully read the
>> implementation, but design/approach explained in the proposed log
>> messages are very sound), and I think 3/3 is a good thing to do,
>> too, in the new world order after d3038d2.
>
> I think it's rather the opposite. In a post-d3038d2 world, a missing
> object is _more_ likely to be a real corruption, and we would probably
> prefer to complain about it. I am on the fence though.
Sorry, but I wasn't talking about that far in the future.
In the immediate future that necessitates patches 1 and 2, a warning
on such a missing object from the codepath in 3 would be equally
annoying noise, no? And a purely post-d3038d2 world, all of these
warnings may be pointing at a real corruption, as you referred to as
"yet another possibility".
As you said, these should have been part of ignore-missing-links, so
I'd say we should treat the codepaths that special case the callers
that pass that option the same way.
Having said all that, I do not think it is healthy to assume that
pre-d3038d2 prune is the only thing that may leave an incomplete and
unreachable island of objects in the repository (two easy ways to do
so are to interrupt unpack-objects or the commit walker dumb fetch).
So from that point of view, these three patches are reasonable
things to keep even in the longer term (in other words, I do not
think "yet another possibility" of waiting for the older versions of
gc/prune to die out is a viable solution to the issue Stefan Näwe
noticed).
Thanks.
prev parent reply other threads:[~2015-06-01 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 7:37 git gc gives "error: Could not read..." Stefan Näwe
2015-06-01 8:14 ` Jeff King
2015-06-01 8:40 ` Stefan Näwe
2015-06-01 8:52 ` Jeff King
2015-06-01 9:14 ` Stefan Näwe
2015-06-01 9:58 ` Jeff King
2015-06-01 10:08 ` Stefan Näwe
2015-06-01 10:22 ` Jeff King
2015-06-01 9:54 ` [RFC/PATCH 0/3] silence missing-link warnings in some cases Jeff King
2015-06-01 9:56 ` [PATCH 1/3] add quieter versions of parse_{tree,commit} Jeff King
2015-06-01 9:56 ` [PATCH 2/3] silence broken link warnings with revs->ignore_missing_links Jeff King
2015-06-01 9:56 ` [PATCH 3/3] suppress errors on missing UNINTERESTING links Jeff King
2015-06-01 15:03 ` [RFC/PATCH 0/3] silence missing-link warnings in some cases Junio C Hamano
2015-06-01 15:41 ` Jeff King
2015-06-01 16:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7frn8l2r.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=stefan.naewe@atlas-elektronik$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox