From: Junio C Hamano <gitster@pobox•com>
To: Duy Nguyen <pclouds@gmail•com>
Cc: Mike Hommey <mh@glandium•org>, Git Mailing List <git@vger•kernel.org>
Subject: Re: Bug in git-verify-pack or in its documentation?
Date: Thu, 19 Mar 2015 10:59:32 -0700 [thread overview]
Message-ID: <xmqq7fuckgvv.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CACsJy8B=S9ajzj9N-JoCou6_FVj9VgCHEkZ2AiQ=zR=aCLKXuw@mail.gmail.com> (Duy Nguyen's message of "Wed, 18 Mar 2015 19:31:19 +0700")
Duy Nguyen <pclouds@gmail•com> writes:
> On Mon, Mar 16, 2015 at 8:18 PM, Mike Hommey <mh@glandium•org> wrote:
>> On Mon, Mar 16, 2015 at 05:13:25PM +0700, Duy Nguyen wrote:
>>> On Mon, Mar 16, 2015 at 3:05 PM, Mike Hommey <mh@glandium•org> wrote:
>>> > Hi,
>>> >
>>> > git-verify-pack's man page says the following about --stat-only:
>>> >
>>> > Do not verify the pack contents; only show the histogram of delta
>>> > chain length. With --verbose, list of objects is also shown.
>>> >
>>> > However, there is no difference of output between --verbose and
>>> > --verbose --stat-only (and in fact, looking at the code, only one of
>>> > them has an effect, --stat-only having precedence).
>>>
>>> There is. very-pack --verbose would show a lot of "<sha-1> <type>
>>> <"random" numbers>" lines before the histogram while --stat-only (with
>>> or without --verbose) would only show the histogram.
>>
>> Err, I meant between --stat-only and --verbose --stat-only.
>
> Yeah --verbose is always ignored when --stat-only is set. This command is funny.
I would disagree. "--verbose" is "do whatever you are told to do
but you can enhance the result by giving more verbose output".
To understand what I mean, compare "git verify-pack" (no other
options) and "git verify-pack --verbose".
Now, when you are asking the command to show the statistics only and
nothing else, there may be nothing useful that you can output to
enhance the "stat-only" output. "git verify-pack --stat-only" (no
other options) and "git verify-pack --stat-only --verbose" can
produce exactly the same result in such a case.
So I do not see anything funny there.
prev parent reply other threads:[~2015-03-19 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 8:05 Bug in git-verify-pack or in its documentation? Mike Hommey
2015-03-16 10:13 ` Duy Nguyen
2015-03-16 13:18 ` Mike Hommey
2015-03-18 12:31 ` Duy Nguyen
2015-03-19 17:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fuckgvv.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mh@glandium$(echo .)org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox