From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Kyle J. McKay" <mackyle@gmail•com>,
Git mailing list <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] help.c: use SHELL_PATH instead of hard-coded "/bin/sh"
Date: Mon, 09 Mar 2015 19:21:45 -0700 [thread overview]
Message-ID: <xmqq7fup618m.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150309072040.GA28148@peff.net> (Jeff King's message of "Mon, 9 Mar 2015 03:20:40 -0400")
Jeff King <peff@peff•net> writes:
> However, that is _not_ what we currently do with run-command's
> use_shell directive. There we put SHELL_PATH as argv[0], and run:
>
> execv(argv[0], argv);
> ...
> If we want to maintain consistency with the rest of our uses of
> run-command, it would be just your original:
>
> execl(SHELL_PATH, SHELL_PATH, "-c", shell_cmd.buf, NULL);
>
> That makes the most sense to me, unless we are changing run-command's
> behavior, too.
OK, then the original under discussion is fine as-is.
Thanks for sanity checking.
prev parent reply other threads:[~2015-03-10 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 5:07 [PATCH 1/2] git-compat-util.h: move SHELL_PATH default into header Kyle J. McKay
2015-03-08 5:08 ` [PATCH 2/2] help.c: use SHELL_PATH instead of hard-coded "/bin/sh" Kyle J. McKay
2015-03-08 7:52 ` Junio C Hamano
2015-03-09 6:32 ` Kyle J. McKay
2015-03-09 7:20 ` Jeff King
2015-03-10 2:21 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fup618m.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mackyle@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox