From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: Jeff King <peff@peff•net>,
Dmitry Neverov <dmitry.neverov@gmail•com>,
git@vger•kernel.org
Subject: Re: Git gc removes all packs
Date: Tue, 17 Feb 2015 13:57:05 -0800 [thread overview]
Message-ID: <xmqq7fvg19se.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54E3A695.1050708@alum.mit.edu> (Michael Haggerty's message of "Tue, 17 Feb 2015 21:37:41 +0100")
Michael Haggerty <mhagger@alum•mit.edu> writes:
> On 02/17/2015 05:55 PM, Jeff King wrote:
>> On Tue, Feb 17, 2015 at 05:39:27PM +0100, Michael Haggerty wrote:
>>
>>> There's a bunch of code in refs.c that is there explicitly for reading
>>> loose references that are symlinks. If the link contents literally start
>>> with "refs/", then they are read and treated as a symbolic ref.
>>> Otherwise, the symlink is just followed.
>> ...
> Yes, this makes sense too. But my point was that sticking symlinks to
> random files in your refs hierarchy is pretty questionable even *before*
> the symlink gets broken. If we would warn the user as soon as we saw
> such a thing, then the user's problem would never have advanced as far
> as it did. Do you think that emitting warnings on *intact* symlinks is
> too draconian?
Do you mean that we would end up reading refs/heads/hold if the user
did this:
git rev-parse --verify HEAD -- >precious
ln -s ../../../precious .git/refs/heads/hold
because that symbolic link does not begin with "refs/", and is an
accident waiting to happen so we should forbid it in the longer
term and warning when we see it would be the first step?
next prev parent reply other threads:[~2015-02-17 21:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 15:13 Git gc removes all packs Dmitry Neverov
2015-02-05 20:03 ` Jeff King
2015-02-17 16:39 ` Michael Haggerty
2015-02-17 16:55 ` Jeff King
2015-02-17 20:37 ` Michael Haggerty
2015-02-17 21:57 ` Junio C Hamano [this message]
2015-02-17 22:19 ` Michael Haggerty
2015-02-18 7:13 ` Junio C Hamano
2015-02-27 10:16 ` Dmitry Neverov
2015-02-27 13:14 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fvg19se.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dmitry.neverov@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox