From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Ramsay Jones <ramsay@ramsay1•demon.co.uk>,
GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH] builtin/commit.c: fix type warnings from gcc and sparse
Date: Fri, 29 Aug 2014 15:17:33 -0700 [thread overview]
Message-ID: <xmqq7g1r3pqa.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140829184435.GA29456@peff.net> (Jeff King's message of "Fri, 29 Aug 2014 14:44:35 -0400")
Jeff King <peff@peff•net> writes:
> On Fri, Aug 29, 2014 at 05:36:21PM +0100, Ramsay Jones wrote:
>
>> On 32-bit platforms (only), gcc and sparse both issue warnings
>> about the type of the pointer expression passed as the third
>> argument to find_commit_header(). In order to suppress the
>> warnings, we simply change the type of the 'len' variable to
>> size_t.
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
>
> Thanks, this looks good to me. I think I just switched between size_t
> and "unsigned long" during the development and forgot to tweak this
> spot.
>
>> If you need to re-roll your 'jk/commit-author-parsing' series, could
>> you please squash this into the equivalent of commit 95b5989
>> ("determine_author_info(): reuse parsing functions", 27-08-2014).
>
> I don't think I have any other reason to re-roll at this point. I'm
> happy to have this on top, or it can be squashed into the second from
> the top (95b5989) if we want to keep the history cleaner.
>
> I'm also happy to re-roll just for this, but my impression is that is
> not really any easier on Junio than just squashing a patch in.
Thanks for being very considerate ;-) Have squashed it in with
"rebase -i" while preparing for the mid-day pushout.
prev parent reply other threads:[~2014-08-29 22:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 16:36 [PATCH] builtin/commit.c: fix type warnings from gcc and sparse Ramsay Jones
2014-08-29 18:44 ` Jeff King
2014-08-29 22:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7g1r3pqa.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox