From: Junio C Hamano <gitster@pobox•com>
To: Andreas Schwab <schwab@linux-m68k•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Add grep.fullName config variable
Date: Mon, 17 Mar 2014 15:21:41 -0700 [thread overview]
Message-ID: <xmqq7g7sbh56.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <874n2w3abu.fsf@igel.home> (Andreas Schwab's message of "Mon, 17 Mar 2014 20:16:05 +0100")
Andreas Schwab <schwab@linux-m68k•org> writes:
> This configuration variable sets the default for the --full-name option.
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k•org>
> ---
Would this change break Porcelains (e.g. Emacs modes) and force them
to be updated to explicitly pass --no-full-name to unbreak them?
> Documentation/git-grep.txt | 3 +++
> grep.c | 5 +++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
> index f837334..31811f1 100644
> --- a/Documentation/git-grep.txt
> +++ b/Documentation/git-grep.txt
> @@ -53,6 +53,9 @@ grep.extendedRegexp::
> option is ignored when the 'grep.patternType' option is set to a value
> other than 'default'.
>
> +grep.fullName::
> + If set to true, enable '--full-name' option by default.
> +
>
> OPTIONS
> -------
> diff --git a/grep.c b/grep.c
> index c668034..ece04bf 100644
> --- a/grep.c
> +++ b/grep.c
> @@ -86,6 +86,11 @@ int grep_config(const char *var, const char *value, void *cb)
> return 0;
> }
>
> + if (!strcmp(var, "grep.fullname")) {
> + opt->relative = !git_config_bool(var, value);
> + return 0;
> + }
> +
> if (!strcmp(var, "color.grep"))
> opt->color = git_config_colorbool(var, value);
> else if (!strcmp(var, "color.grep.context"))
> --
> 1.9.0
next prev parent reply other threads:[~2014-03-17 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 19:16 [PATCH] Add grep.fullName config variable Andreas Schwab
2014-03-17 22:21 ` Junio C Hamano [this message]
2014-03-18 10:16 ` Andreas Schwab
2014-03-18 18:39 ` Junio C Hamano
2014-03-18 19:51 ` Andreas Schwab
2014-03-18 20:16 ` Junio C Hamano
2014-03-18 20:01 ` Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2014-03-12 7:11 Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7g7sbh56.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=schwab@linux-m68k$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox