Subject: Re: [PATCH v6 03/10] transport-helper: add 'force' to 'export' helpers

From: Junio C Hamano <[email-masked]>
Date: Mon, 11 Nov 2013 15:28:26 -0800

Felipe Contreras <[email-masked]> writes:

> Otherwise they cannot know when to force the push or not (other than
> hacks).
>
> Tests-by: Richard Hansen <[email-masked]>
> Documentation-by: Richard Hansen <[email-masked]>
> Signed-off-by: Felipe Contreras <[email-masked]>
> ---

Didn't we agree that this should be warn, not die?

> +	if (flags & TRANSPORT_PUSH_FORCE) {
> +		if (set_helper_option(transport, "force", "true") != 0)
> +			die("helper %s does not support 'force'", data->name);
> +	}
> +
>  	helper = get_helper(transport);
>  
>  	write_constant(helper->in, "export\n");