From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Duy Nguyen <pclouds@gmail•com>,
Git Mailing List <git@vger•kernel.org>,
jc@sahnwaldt•de
Subject: Re: [RFC/PATCH] checkout: allow dwim for branch creation for "git checkout $branch --"
Date: Wed, 16 Oct 2013 14:39:15 -0700 [thread overview]
Message-ID: <xmqq7gdc6gl8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: vpqob7huhyw.fsf@anie.imag.fr
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
> Duy Nguyen <pclouds@gmail•com> writes:
>
>> has_dash_dash is calculated as (argc > 1) && !strcmp(argv[1], "--"),
>> so when argc == 1, the has_dash_dash must be zero, the "&&
>> !has_dash_dash" is redundant.
>
> Yes, but I'd rather not have to read the detailed definition of
> has_dash_dash to understand the code. With my version, the name of the
> variable is actually sufficient to understand.
>
>> But it makes me wonder what we do with "git checkout abc def -- xyz".
>
> Ouch. Both old and new say
> ...
> I'll resend, together with tweaks to the first patch.
Did anything further happen to this discussion? Is v3 the version
with agreement among the list members I just should pick up?
next prev parent reply other threads:[~2013-10-16 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 12:49 [RFC/PATCH] checkout: allow dwim for branch creation for "git checkout $branch --" Matthieu Moy
2013-09-25 13:22 ` Duy Nguyen
2013-09-25 13:52 ` Matthieu Moy
2013-09-25 19:11 ` Duy Nguyen
2013-10-16 21:39 ` Junio C Hamano [this message]
2013-10-17 11:13 ` Matthieu Moy
2013-10-17 20:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7gdc6gl8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=jc@sahnwaldt$(echo .)de \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox