public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Richard Hansen <rhansen@bbn•com>
Cc: git@vger•kernel.org, peff@peff•net, sunshine@sunshineco•com
Subject: Re: [PATCH v4] peel_onion(): add support for <rev>^{tag}
Date: Tue, 03 Sep 2013 13:10:44 -0700	[thread overview]
Message-ID: <xmqq7gexr7i3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1378237816-28671-1-git-send-email-rhansen@bbn.com> (Richard Hansen's message of "Tue, 3 Sep 2013 15:50:16 -0400")

Richard Hansen <rhansen@bbn•com> writes:

> diff --git a/t/t1511-rev-parse-caret.sh b/t/t1511-rev-parse-caret.sh
> index eaefc77..15973f2 100755
> --- a/t/t1511-rev-parse-caret.sh
> +++ b/t/t1511-rev-parse-caret.sh
> @@ -54,6 +54,13 @@ test_expect_success 'ref^{tree}' '
>  	test_must_fail git rev-parse blob-tag^{tree}
>  '
>  
> +test_expect_success 'ref^{tag}' '
> +	test_must_fail git rev-parse HEAD^{tag} &&
> +	git rev-parse commit-tag >expected &&
> +	git rev-parse commit-tag^{tag} >actual &&
> +	test_cmp expected actual
> +'
> +

Looks good to me.  Testing both failure case and success case.

Thanks; will queue.

next prev parent reply	other threads:[~2013-09-03 20:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 19:50 [PATCH v4] peel_onion(): add support for <rev>^{tag} Richard Hansen
2013-09-03 20:10 ` Junio C Hamano [this message]
2013-09-03 20:20 ` [PATCH 2/1] peel_onion: do not assume length of x_type globals Jeff King
2013-09-03 20:27   ` [PATCH 2/1 alt] " Jeff King
2013-09-03 20:46     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7gexr7i3.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=rhansen@bbn$(echo .)com \
    --cc=sunshine@sunshineco$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox