From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Phil Hord <hordp@cisco•com>,
git@vger•kernel.org, phil.hord@gmail•com,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCHv2] grep: use slash for path delimiter, not colon
Date: Mon, 26 Aug 2013 20:37:37 -0700 [thread overview]
Message-ID: <xmqq7gf7iz26.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20130826195331.GA21051@sigill.intra.peff.net> (Jeff King's message of "Mon, 26 Aug 2013 15:53:31 -0400")
Jeff King <peff@peff•net> writes:
> On Mon, Aug 26, 2013 at 03:28:26PM -0400, Jeff King wrote:
>
>> Changing the object_array API would be hard, but I don't think we need
>> to do it here. Can we simply stop using object_array to pass the list,
>> and instead just have a custom list?
>>
>> I'll see how painful that is.
>
> Not very, I think. Here's the series.
>
> [1/2]: grep: stop using object_array
> [2/2]: grep: use slash for path delimiter, not colon
I agree that if we were to do this, these patches show a reasonable
approach to do so.
I however am not yet convinced if its output is necessarily better
X-<.
prev parent reply other threads:[~2013-08-27 3:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 14:46 [PATCHv2] grep: use slash for path delimiter, not colon Phil Hord
2013-08-26 19:28 ` Jeff King
2013-08-26 19:53 ` Jeff King
2013-08-26 19:54 ` [PATCH 1/2] grep: stop using object_array Jeff King
2013-08-26 19:56 ` [PATCH 2/2] grep: use slash for path delimiter, not colon Jeff King
2013-08-26 20:13 ` Johannes Sixt
2013-08-26 20:52 ` Phil Hord
2013-08-26 20:52 ` Jeff King
2013-08-26 21:03 ` Phil Hord
2013-08-26 21:13 ` Jeff King
2013-08-27 3:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7gf7iz26.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hordp@cisco$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=phil.hord@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox