Subject: Re: [PATCH v5 0/2] includeIf: add "worktree" condition for matching working tree path

From: Junio C Hamano <[email-masked]>
Date: Mon, 25 May 2026 18:24:48 +0900

Chen Linxuan <[email-masked]> writes:

> On Mon, May 25, 2026 at 3:31 PM Junio C Hamano <[email-masked]> wrote:
>>
>> Chen Linxuan via B4 Relay <[email-masked]>
>> writes:
>>
>> > Changes in v5:
>> > - Fix Windows CI failure: use `**` glob pattern instead of `/` in the
>> >   "worktree without repository" tests, since `/` as a path pattern is
>> >   Unix-specific and does not match Windows paths.
>>
>> Would it have worked if you used something like "[/\\].path",
>> instead of "/.path", to cover directory delimiters for both systems?
>>
>> I am not asking to make further changes.  I am trying to understand
>> what the extent of the problem was.
>
> The root cause is that on Windows,
> strbuf_realpath() returns paths with a drive letter prefix (e.g.
> D:/a/git/...), which does not start with /.

Ahh, OK, so the "Changes in v5" description was misleading.

This exchange suggests that the use of **/.path in the test deserves
some in-code comment to explain why we use such an unusual and loose
construct.

Thanks.