Subject: Re: [GSoC][PATCH 1/5] builtin/pack-refs: factor out core logic into a helper

From: Junio C Hamano <[email-masked]>
Date: Tue, 02 Sep 2025 22:25:44 -0700

Patrick Steinhardt <[email-masked]> writes:

>>  builtin/pack-refs.c | 31 ++++++++++++++++++++-----------
>>  pack-refs.h         | 22 ++++++++++++++++++++++
>>  2 files changed, 42 insertions(+), 11 deletions(-)
>>  create mode 100644 pack-refs.h
>
> Shouldn't that header live in "builtin/pack-refs.h"? Makes it way more
> obvious that it exposes functions from "builtin/pack-refs.c".

There shouldn't be any *.h files in builtin/.  since the top-level
is where the library-ish reusable things live, so that they can
eventually be used by more than one *.c files in builtin/ and also
by other *.c files outside builtin.