Subject: Re: [PATCH 4/4] Fix unreachable-code warning with clang on Windows

From: Junio C Hamano <[email-masked]>
Date: Wed, 04 Jun 2025 08:50:28 -0700

Patrick Steinhardt <[email-masked]> writes:

> The function won't cause the error, but the macro will. So wouldn't it
> make more sense to wrap the macro itself in `NOT_CONSTANT`, like this:
>
>     #define create_ref_symlink(a, b) NOT_CONSTANT(-1)

That's clever ;-).

We cannot unfortunatel do the same at the site that the macro
NOT_CONSTANT() was invented for, though.