From: Junio C Hamano <gitster@pobox•com>
To: Rodrigo Carvalho <rodrigorsdc@gmail•com>
Cc: git@vger•kernel.org, Eric Sunshine <sunshine@sunshineco•com>,
Johannes Sixt <j6t@kdbg•org>
Subject: Re: [PATCH v2] userdiff: add support for R programming language
Date: Tue, 03 Jun 2025 11:20:51 -0700 [thread overview]
Message-ID: <xmqq8qm8k7p8.fsf@gitster.g> (raw)
In-Reply-To: <20250529221805.97036-1-rodrigorsdc@gmail.com> (Rodrigo Carvalho's message of "Thu, 29 May 2025 19:16:41 -0300")
Rodrigo Carvalho <rodrigorsdc@gmail•com> writes:
> The patch appends userdiff.c file in order to support R programming
> language function header. This will be useful for those who use Git
> for versioning .R files.
>
> Also, add three userdiff tests for R programming language
> files. These files define simple function and nested function,
> with and without indentation.
>
> Signed-off-by: Rodrigo Carvalho <rodrigorsdc@gmail•com>
> ---
> Changes in v2:
> - Add support for function defined by '='
> - Replace word regex to '[^ \t']
> - Add new test that handles with nested function
Sorry, but this fell of the radar.
It seems all the reviewer comments on the previous round have been
addressed. If everybody is happy with this version, let's merge it
down to 'next', for the next cycle.
Thanks.
next prev parent reply other threads:[~2025-06-03 18:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 21:02 [PATCH 1/2] userdiff: add support for R programming language Rodrigo Carvalho
2025-05-25 21:02 ` [PATCH 2/2] t4018: add two userdiff tests for R language Rodrigo Carvalho
2025-05-25 22:42 ` Eric Sunshine
2025-05-26 5:57 ` [PATCH 1/2] userdiff: add support for R programming language Johannes Sixt
2025-05-27 15:04 ` Junio C Hamano
2025-05-29 21:36 ` Rodrigo Carvalho
2025-05-29 22:16 ` [PATCH v2] " Rodrigo Carvalho
2025-06-03 18:20 ` Junio C Hamano [this message]
2025-06-03 21:15 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8qm8k7p8.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=rodrigorsdc@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox