From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Dragan Simic <dsimic@manjaro•org>,
git@vger•kernel.org, rsbecker@nexbridge•com,
github@seichter•de
Subject: Re: [PATCH v4 4/4] config.txt: describe handling of whitespace further
Date: Thu, 21 Mar 2024 00:32:03 -0700 [thread overview]
Message-ID: <xmqq8r2cca6k.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cSYhYBa0NsvJCOYo4JsWzLJT9rU++U1QKA3jRB6Cptbhw@mail.gmail.com> (Eric Sunshine's message of "Thu, 21 Mar 2024 01:11:26 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> Whitespace surrounding `name`, `=` and `value` is ignored. If
> `value` is surrounding by double quotation marks (`"`), all
> characters within the quoted string are retained verbatim,
> including whitespace. Comments starting with either `#` or `;` and
> extending to the end of line are discarded. A line that defines a
> value can be continued to the next line by ending it with a `\`;
> the backslash and the end-of-line are stripped.
Nice, but I am not sure how this captures how whitespaces between
value and comment are handled, e.g., in this line
| name = value # comment$
humans know the space before '#' is removed because it is
"whitespace surrounding value". But there is a bit of chicken and
egg problem; before you realize '# comment' is a comment and strip
it from the line, you do not know where value ends, so your reading
of the above need to backtrack.
next prev parent reply other threads:[~2024-03-21 7:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 4:17 [PATCH v4 0/4] Fix a bug in configuration parsing, and improve tests and documentation Dragan Simic
2024-03-21 4:17 ` [PATCH v4 1/4] config: minor addition of whitespace Dragan Simic
2024-03-21 4:17 ` [PATCH v4 2/4] config: really keep value-internal whitespace verbatim Dragan Simic
2024-03-21 4:17 ` [PATCH v4 3/4] t1300: add more tests for whitespace and inline comments Dragan Simic
2024-03-21 4:55 ` Eric Sunshine
2024-03-21 5:01 ` Dragan Simic
2024-03-21 4:17 ` [PATCH v4 4/4] config.txt: describe handling of whitespace further Dragan Simic
2024-03-21 5:11 ` Eric Sunshine
2024-03-21 5:16 ` Dragan Simic
2024-03-21 5:21 ` Eric Sunshine
2024-03-21 5:31 ` Dragan Simic
2024-03-21 7:32 ` Junio C Hamano [this message]
2024-03-21 4:50 ` [PATCH v4 0/4] Fix a bug in configuration parsing, and improve tests and documentation Eric Sunshine
2024-03-21 4:58 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8r2cca6k.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=dsimic@manjaro$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=github@seichter$(echo .)de \
--cc=rsbecker@nexbridge$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox