From: Junio C Hamano <gitster@pobox•com>
To: Kyle Lippincott <spectral@google•com>, Calvin Wan <calvinwan@google•com>
Cc: git@vger•kernel.org, Johannes Schindelin <johannes.schindelin@gmx•de>
Subject: Re: [PATCH] cmake: adapt to the Git Standard Library
Date: Tue, 27 Feb 2024 15:10:28 -0800 [thread overview]
Message-ID: <xmqq8r35o657.fsf@gitster.g> (raw)
In-Reply-To: <xmqqcyshsqcf.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 27 Feb 2024 10:40:32 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail•com>
> writes:
>
>> From: Johannes Schindelin <johannes.schindelin@gmx•de>
>>
>> In the commit "git-std-lib: introduce Git Standard Library" of the
>> `cw/git-std-lib` topic, the Makefile was restructured in a manner that
>> requires the CMake definition to follow suit to be able to build Git.
>>
>> This commit adjusts the CMake definition accordingly.
>>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx•de>
>> ---
>> cmake: adapt to the Git Standard Library
>>
>> The usual CMake adjustments. This is based on cw/git-std-lib.
>
> Thanks for a fix.
>
> std-lib folks, can you fold this patch (with authorship credits
> intact) into your series when it gets rerolled from here on?
Forgot to Cc: folks who can take care of this for me.
next prev parent reply other threads:[~2024-02-27 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 14:44 [PATCH] cmake: adapt to the Git Standard Library Johannes Schindelin via GitGitGadget
2024-02-27 18:40 ` Junio C Hamano
2024-02-27 23:10 ` Junio C Hamano [this message]
2024-02-27 23:14 ` Calvin Wan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8r35o657.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=calvinwan@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=spectral@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox