public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: "Jiang Xin" <worldhello.net@gmail•com>,
	"Jeff Hostetler" <jeffhostetler@github•com>,
	"Alexander Shopov" <ash@kambanaria•org>,
	"Git List" <git@vger•kernel.org>,
	jmas@softcatala•org, alexhenrie24@gmail•com,
	ralf.thielow@gmail•com, matthias.ruester@gmail•com,
	phillip.szelat@gmail•com, vyruss@hellug•gr,
	christopher.diaz.riv@gmail•com, jn.avila@free•fr,
	flashcode@flashtux•org, bagasdotme@gmail•com,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
	alessandro.menti@alessandromenti•it, elongbug@gmail•com,
	cwryu@debian•org, uneedsihyeon@gmail•com, arek_koz@o2•pl,
	dacs.git@brilhante•top, "insolor@gmail•com" <insolor@gmail•com>,
	peter@softwolves•pp.se, bitigchi@me•com, ark@cho•red,
	kate@kgthreads•com, "vnwildman@gmail•com" <vnwildman@gmail•com>,
	pclouds@gmail•com, "dyroneteng@gmail•com" <dyroneteng@gmail•com>,
	"oldsharp@gmail•com" <oldsharp@gmail•com>,
	"lilydjwg@gmail•com" <lilydjwg@gmail•com>,
	"pan93412@gmail•com" <pan93412@gmail•com>,
	"franklin@goodhorse•idv.tw" <franklin@goodhorse•idv.tw>
Subject: Re: Is there any interest in localizing term delimiters in git messages?
Date: Thu, 19 Oct 2023 13:16:55 -0700	[thread overview]
Message-ID: <xmqq8r7yweo8.fsf@gitster.g> (raw)
In-Reply-To: <20231019194747.GC25301@tb-raspi4> ("Torsten Bögershausen"'s message of "Thu, 19 Oct 2023 21:47:47 +0200")

Torsten Bögershausen <tboegi@web•de> writes:

> The switch case covers all 8 values of "enum crlf_action",
> and removing these 2 lines
>  -	warning("Illegal crlf_action %d\n", (int)crlf_action);
>  -	return core_eol;
> does still compile without a compiler warning.
> So yes, a BUG is more appropriate here.

Yeah, and if our expectation is whenever we add a new value to enum
convert_crlf_action, we will handle in and return from the switch
statement, so I agree with you that BUG() is more appropriate.

Thanks for a quick response.  Note that this was something we
discovered while talking about i18n and no immediate action is
required---it is not like we saw a report that tells us that end
users are actively getting confused by this message.

Thanks.

next prev parent reply	other threads:[~2023-10-19 20:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 21:09 Is there any interest in localizing term delimiters in git messages? Alexander Shopov
2023-10-17 21:49 ` Junio C Hamano
2023-10-18  2:01   ` Jiang Xin
2023-10-18  2:47     ` Junio C Hamano
2023-10-18  3:08       ` [PATCH] commit: do not use cryptic "new_index" in end-user facing messages Junio C Hamano
2023-10-19  5:08       ` Is there any interest in localizing term delimiters in git messages? Jiang Xin
2023-10-19 17:52         ` Junio C Hamano
2023-10-19 18:07           ` Jeff Hostetler
2023-10-19 19:18             ` Junio C Hamano
2023-10-19 19:47           ` Torsten Bögershausen
2023-10-19 20:16             ` Junio C Hamano [this message]
2023-10-21  9:30 ` Peter Krefting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8r7yweo8.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=alessandro.menti@alessandromenti$(echo .)it \
    --cc=alexhenrie24@gmail$(echo .)com \
    --cc=arek_koz@o2$(echo .)pl \
    --cc=ark@cho$(echo .)red \
    --cc=ash@kambanaria$(echo .)org \
    --cc=avarab@gmail$(echo .)com \
    --cc=bagasdotme@gmail$(echo .)com \
    --cc=bitigchi@me$(echo .)com \
    --cc=christopher.diaz.riv@gmail$(echo .)com \
    --cc=cwryu@debian$(echo .)org \
    --cc=dacs.git@brilhante$(echo .)top \
    --cc=dyroneteng@gmail$(echo .)com \
    --cc=elongbug@gmail$(echo .)com \
    --cc=flashcode@flashtux$(echo .)org \
    --cc=franklin@goodhorse$(echo .)idv.tw \
    --cc=git@vger$(echo .)kernel.org \
    --cc=insolor@gmail$(echo .)com \
    --cc=jeffhostetler@github$(echo .)com \
    --cc=jmas@softcatala$(echo .)org \
    --cc=jn.avila@free$(echo .)fr \
    --cc=kate@kgthreads$(echo .)com \
    --cc=lilydjwg@gmail$(echo .)com \
    --cc=matthias.ruester@gmail$(echo .)com \
    --cc=oldsharp@gmail$(echo .)com \
    --cc=pan93412@gmail$(echo .)com \
    --cc=pclouds@gmail$(echo .)com \
    --cc=peter@softwolves$(echo .)pp.se \
    --cc=phillip.szelat@gmail$(echo .)com \
    --cc=ralf.thielow@gmail$(echo .)com \
    --cc=tboegi@web$(echo .)de \
    --cc=uneedsihyeon@gmail$(echo .)com \
    --cc=vnwildman@gmail$(echo .)com \
    --cc=vyruss@hellug$(echo .)gr \
    --cc=worldhello.net@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox