From: Junio C Hamano <gitster@pobox•com>
To: Todd Zullinger <tmz@pobox•com>
Cc: git@vger•kernel.org, "Jeff King" <peff@peff•net>,
"René Scharfe" <l.s.r@web•de>
Subject: Re: t3206-range-diff failures on non x86 arches
Date: Wed, 01 Mar 2023 13:36:02 -0800 [thread overview]
Message-ID: <xmqq8rggm9x9.fsf@gitster.g> (raw)
In-Reply-To: <Y/++KovrW+08XRQc@pobox.com> (Todd Zullinger's message of "Wed, 1 Mar 2023 16:05:46 -0500")
Todd Zullinger <tmz@pobox•com> writes:
> I wrote:
>> Junio C Hamano wrote:
>>>> On Fedora, rc1 fails most tests in t3206-range-diff.sh on 3
>>>> of the 5 supported architectures: aarch64, ppc64le, and
>>>> s390x. These tests succeed on i686 and x86_64. They passed
>>>> on all arches with rc0.
>>>
>>> Sounds like something d9165bef (range-diff: avoid compiler warning
>>> when char is unsigned, 2023-02-28) may fix. Can you try merging it
>>> to rc1 yourself and see how the result does?
>>
>> Oh, indeed it does. Thanks for the pointer. I'm running
>> a build with that now.
>
> Confirmed. That fixes the tests. Thanks!
Will merge that fix by Réne down to 'master'.
Thanks for promptly reporting the problem and its fix.
next prev parent reply other threads:[~2023-03-01 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 17:40 [ANNOUNCE] Git v2.40.0-rc1 Junio C Hamano
2023-03-01 19:37 ` t3206-range-diff failures on non x86 arches (was: [ANNOUNCE] Git v2.40.0-rc1) Todd Zullinger
2023-03-01 19:52 ` Jeff King
2023-03-01 20:01 ` t3206-range-diff failures on non x86 arches Junio C Hamano
2023-03-01 20:21 ` Todd Zullinger
2023-03-01 21:05 ` Todd Zullinger
2023-03-01 21:36 ` Junio C Hamano [this message]
2023-03-14 11:08 ` Teng Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rggm9x9.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
--cc=peff@peff$(echo .)net \
--cc=tmz@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox