Subject: Re: [PATCH v2] lstat(mingw): correctly detect ENOTDIR scenarios

From: Junio C Hamano <[email-masked]>
Date: Thu, 28 Jul 2022 10:37:13 -0700

"Johannes Schindelin via GitGitGadget" <[email-masked]>
writes:

> In that code, the return value of `GetFileAttributesW()` is interpreted
> as an enum value, not as a bit field, so that a perfectly fine leading
> directory can be misdetected as "not a directory".

Nicely analyzed.  So after all ENOTDIR was a buggy response and by
fixing it we help all callers of lstat(), as pointed out in the
earlier review.

>      * Thanks to Eric's excellent review, the reporter and I dug deeper and
>        figured out the real bug (and fix).

Yeah, thanks all.

Will queue.