From: Junio C Hamano <gitster@pobox•com>
To: Lars Schneider <larsxschneider@gmail•com>
Cc: "Eric Sunshine" <sunshine@sunshineco•com>,
"Git List" <git@vger•kernel.org>,
"Luke Diamand" <luke@diamand•org>,
"Torsten Bögershausen" <tboegi@web•de>
Subject: Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error
Date: Tue, 22 Sep 2015 09:02:09 -0700 [thread overview]
Message-ID: <xmqq8u7y5toe.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <9F835973-7045-4AA7-A0B0-D3D3C6F25D73@gmail.com> (Lars Schneider's message of "Tue, 22 Sep 2015 12:09:20 +0200")
Lars Schneider <larsxschneider@gmail•com> writes:
> This works.
OK, and thanks; as I don't do perforce, the squash was without any
testing.
> Do we need the “-e” option?
In syntactic sense, no, but our codebase tends to prefer to have
one, because it is easier to spot which ones are the instructions if
you consistently have "-e" even when you give only one.
next prev parent reply other threads:[~2015-09-22 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 10:01 [PATCH v4 0/2] git-p4: handle "Translation of file content failed" larsxschneider
2015-09-21 10:01 ` [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error larsxschneider
2015-09-21 18:09 ` Junio C Hamano
2015-09-21 23:03 ` Lars Schneider
2015-09-21 23:54 ` Eric Sunshine
2015-09-22 1:10 ` Junio C Hamano
2015-09-22 10:09 ` Lars Schneider
2015-09-22 16:02 ` Junio C Hamano [this message]
2015-09-22 19:11 ` Michael Blume
2015-09-22 19:17 ` Junio C Hamano
2015-09-23 7:34 ` Lars Schneider
2015-09-22 10:12 ` Lars Schneider
2015-09-22 16:02 ` Junio C Hamano
2015-09-21 10:01 ` [PATCH v4 2/2] git-p4: handle "Translation of file content failed" larsxschneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8u7y5toe.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
--cc=luke@diamand$(echo .)org \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox