From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: Michael Haggerty <mhagger@alum•mit.edu>,
"git\@vger.kernel.org" <git@vger•kernel.org>,
Jeff King <peff@peff•net>
Subject: Re: [PATCHv3] refs.c: enable large transactions
Date: Thu, 23 Apr 2015 18:37:47 -0700 [thread overview]
Message-ID: <xmqq8udi2tn8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYO9NifvWQ7nWHP6==ZFmrMj47-94rEHOhWooR5Nh7EUw@mail.gmail.com> (Stefan Beller's message of "Thu, 23 Apr 2015 17:21:49 -0700")
Stefan Beller <sbeller@google•com> writes:
> On Thu, Apr 23, 2015 at 10:56 AM, Junio C Hamano <gitster@pobox•com> wrote:
>
>>> + int save_errno = errno;
>>> + error("Couldn't reopen %s", lock->lk->filename.buf);
>>
>> No need to change this line, but I noticed that we might want to do
>> something about the first one of the following two:
>
> I personally like to have each error(...) to have a unique string, such
> that when you run into trouble (most likely reported by a user),
> you can easily pinpoint where the exact error is.
I was hoping that the "grep" patterns were strong enough hint, but
let me be explicit. I was commenting on "Could" not being spelled
as "could".
>> $ git grep -e '[ ]error(_*"[A-Z]' | wc -l
>> 146
>> $ git grep -e '[ ]error(_*"[a-z]' | wc -l
>> 390
next prev parent reply other threads:[~2015-04-24 1:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 21:30 [PATCHv3] refs.c: enable large transactions Stefan Beller
2015-04-23 17:56 ` Junio C Hamano
2015-04-24 0:21 ` Stefan Beller
2015-04-24 1:37 ` Junio C Hamano [this message]
2015-04-24 16:16 ` Stefan Beller
2015-04-24 17:19 ` Jeff King
2015-04-24 18:12 ` Jonathan Nieder
2015-04-24 18:31 ` Stefan Beller
2015-04-24 20:17 ` Jeff King
2015-04-25 4:23 ` Junio C Hamano
2015-04-25 5:00 ` Jeff King
2015-04-25 5:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8udi2tn8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox