public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <johannes.schindelin@gmx•de>
Cc: "Torsten Bögershausen" <tboegi@web•de>, git@vger•kernel.org
Subject: Re: [PATCH v2 2/2]  t0027: Support NATIVE_CRLF
Date: Fri, 17 Apr 2015 14:04:11 -0700	[thread overview]
Message-ID: <xmqq8udqpius.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1db9b0b7322c3b8b8e7a76b29b020ad8@www.dscho.org> (Johannes Schindelin's message of "Fri, 17 Apr 2015 21:55:24 +0200")

Johannes Schindelin <johannes.schindelin@gmx•de> writes:

> Hi Torsten,
>
> On 2015-04-17 17:44, Torsten Bögershausen wrote:
>> Without this patch, t0027 expects the native end-of-lines to be a single
>> line feed character. On Windows, however, we set it to a carriage return
>> character followed by a line feed character. Thus, we have to modify
>> t0027 to expect different warnings depending on the end-of-line markers.
>> 
>> Adjust the check of the warnings and use these macros:
>>   WILC:  Warn if LF becomes CRLF
>>   WICL:  Warn if CRLF becomes LF
>>   WAMIX: Mixed line endings: either CRLF->LF or LF->CRLF
>> 
>> Improve the information given by check_warning():
>> Use test_cmp to show which warning is missing (or should'n t be there)
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx•de>
>> Signed-off-by: Torsten Bögershausen <tboegi@web•de>
>
> Thank you so much!
> Dscho

Thanks, is that "Acked-by: Dscho" for both patches?

next prev parent reply	other threads:[~2015-04-17 21:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17 15:44 [PATCH v2 2/2] t0027: Support NATIVE_CRLF Torsten Bögershausen
2015-04-17 17:00 ` Torsten Bögershausen
2015-04-17 19:37   ` Johannes Schindelin
2015-04-17 19:55 ` Johannes Schindelin
2015-04-17 21:04   ` Junio C Hamano [this message]
2015-04-18 14:54     ` Johannes Schindelin
2015-04-17 20:44 ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8udqpius.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=johannes.schindelin@gmx$(echo .)de \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox