Subject: Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions

From: Junio C Hamano <[email-masked]>
Date: Thu, 16 Apr 2015 13:31:31 -0700

Matthieu Moy <[email-masked]> writes:

> Elia Pinto <[email-masked]> writes:
>
>> --- a/t/test-lib-functions.sh
>> +++ b/t/test-lib-functions.sh
>> @@ -478,7 +478,7 @@ test_external_without_stderr () {
>>  test_path_is_file () {
>>  	if ! test -f "$1"
>>  	then
>> -		echo "File $1 doesn't exist. $*"
>> +		echo "File $1 doesn't exist. $2"
>>  		false
>>  	fi
>>  }
>> @@ -486,7 +486,7 @@ test_path_is_file () {
>>  test_path_is_dir () {
>>  	if ! test -d "$1"
>>  	then
>> -		echo "Directory $1 doesn't exist. $*"
>> +		echo "Directory $1 doesn't exist. $2"
>>  		false
>>  	fi
>>  }
>
> Sounds straightforwardly correct to me.

Thanks.  This however makes me wonder why you were nominated for
reviewing this patch, though...