From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: anapsix@random•io, git@vger•kernel.org
Subject: Re: [PATCH 1/2] git remote add: allow re-adding remotes with the same URL
Date: Tue, 23 Dec 2014 10:51:15 -0800 [thread overview]
Message-ID: <xmqq8uhy2o9o.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1412231923560.21312@s15462909.onlinehome-server.info> (Johannes Schindelin's message of "Tue, 23 Dec 2014 19:26:55 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
>> > I hope v2 addresses your concerns.
>>
>> Unfortunately I am still confused.
>>
>> The way the overlong line is folded in the new version of the patch
>> makes it easier to read, but I didn't find a reason why checking the
>> number of fetch_refspec does not go against that goal there.
>
> Since you pointed out rightfully that the main goal is *not* to allow
> multiple `git remote add` to succeed when they try to add the same remote
> with the same URL, I changed the commit message to point out that the goal
> was to handle adding remotes via `git remote add <nick> <url>` when
> url.<url>.insteadOf = <nick> already exists, with the same <nick> and
> <url>.
>
> Since I have no interest in opening the can of worms to allow re-adding
> remotes, I did not touch that part at all, I hope you do not mind.
Oh, don't get me wrong. I do not have any interest in allowing
re-adding remotes, either, so we are on the same page.
I was just saying that it was unclear what ensures that the change
in the codepath only affects the remote setting that conflicts with
"insteadOf" without randomly (read: sometimes it allows, sometimes
it forbids) allowing re-adding remotes.
next prev parent reply other threads:[~2014-12-23 18:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 2:30 [PATCH] remote: allow adding remote w same name as alias Anastas Dancha
2014-12-16 9:01 ` Johannes Schindelin
2014-12-16 14:57 ` Anastas Dancha
2014-12-19 9:37 ` Johannes Schindelin
2014-12-19 15:44 ` Anastas Dancha
2014-12-19 16:30 ` Michael J Gruber
2014-12-20 20:57 ` Anastas Dancha
2014-12-21 20:40 ` Johannes Schindelin
2014-12-16 9:33 ` Michael J Gruber
2014-12-22 17:06 ` [PATCH 0/2] Let `git remote add` play nicer with url.<url>.insteadOf Johannes Schindelin
2014-12-22 17:06 ` [PATCH 1/2] git remote add: allow re-adding remotes with the same URL Johannes Schindelin
2014-12-22 17:49 ` Junio C Hamano
2014-12-23 13:25 ` Johannes Schindelin
[not found] ` <CAPc5daXcXs+Sw8jr65dmLnpf6LQ6Lr34y80bxSf2AhhFyXa_mQ@mail.gmail.com>
2014-12-23 18:26 ` Johannes Schindelin
2014-12-23 18:51 ` Junio C Hamano [this message]
2014-12-22 17:06 ` [PATCH 2/2] Add a regression test for 'git remote add <existing> <same-url>' Johannes Schindelin
2014-12-23 13:24 ` [PATCH v2 0/2] Let `git remote add` play nicer with url.<url>.insteadOf Johannes Schindelin
2014-12-23 13:25 ` [PATCH v2 1/2] git remote: allow adding remotes agreeing with url.<...>.insteadOf Johannes Schindelin
2014-12-23 13:25 ` [PATCH v2 2/2] Add a regression test for 'git remote add <existing> <same-url>' Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8uhy2o9o.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=anapsix@random$(echo .)io \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox