From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Scott Baker <bakers@canbytel•com>, git@vger•kernel.org
Subject: Re: [PATCH 5/7] parse_color: support 24-bit RGB values
Date: Thu, 20 Nov 2014 12:25:29 -0800 [thread overview]
Message-ID: <xmqq8uj539hi.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141120201026.GA4779@peff.net> (Jeff King's message of "Thu, 20 Nov 2014 15:10:27 -0500")
Jeff King <peff@peff•net> writes:
> On Thu, Nov 20, 2014 at 11:44:26AM -0800, Junio C Hamano wrote:
>
>> > @@ -32,10 +32,13 @@ struct color {
>> > COLOR_UNSPECIFIED = 0,
>> > COLOR_NORMAL,
>> > COLOR_ANSI, /* basic 0-7 ANSI colors */
>> > - COLOR_256
>> > + COLOR_256,
>> > + COLOR_RGB
>> > } state;
>> > /* The numeric value for ANSI and 256-color modes */
>> > unsigned char value;
>> > + /* 24-bit RGB color values */
>> > + unsigned char red, green, blue;
>>
>> Do value and rgb have to be both valid at the same time, or is this
>> "we are not wasting a byte by not using a union because it will be
>> in the padding of the outer struct anyway"?
>
> The latter. I started with a union, and then realized that COLOR_ANSI
> and COLOR_256 shared the value, so the union was not saving space and
> just getting in the way (mostly because I had to think of useful names
> for each of the members).
>
> I'd be happy to do it as a union if you think that makes it clearer.
>
> Also, the name "state" should perhaps be "type". It originally
> started as "unspecified or an actual value", which is a state, but
> as I worked, it grew into something more.
I think use of union might be more "kosher", e.g.
struct color_spec {
enum { ... } type;
union {
struct { unsigned char r, g, b; } rgb;
unsigned char ansi;
} u;
} c;
but it is not like you have an array of these things for each slot,
and with the intervening ".u.<type>" you have to write every time
you refer to these fields, the result is probably much uglier and
harder to read. So let's only do s/state/type/ and leave these
"ought to be union but that will be uglier" ones as they are.
next prev parent reply other threads:[~2014-11-20 20:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5462907B.1050207@canbytel.com>
2014-11-12 7:56 ` diff-highlight highlight words? Jeff King
2014-11-12 17:59 ` Scott Baker
2014-11-20 15:14 ` [PATCH 0/7] color fixes and configurable diff-highlight Jeff King
2014-11-20 15:15 ` [PATCH 1/7] docs: describe ANSI 256-color mode Jeff King
2014-11-20 15:15 ` [PATCH 2/7] config: fix parsing of "git config --get-color some.key -1" Jeff King
2014-11-20 15:16 ` [PATCH 3/7] t4026: test "normal" color Jeff King
2014-11-20 18:53 ` Junio C Hamano
2014-11-20 19:00 ` Jeff King
2014-11-20 15:17 ` [PATCH 4/7] parse_color: refactor color storage Jeff King
2014-11-20 19:37 ` Junio C Hamano
2014-12-09 20:14 ` Johannes Sixt
2014-12-09 20:21 ` Jeff King
2014-12-09 20:52 ` Johannes Sixt
2014-12-09 21:01 ` Jeff King
2014-12-09 20:56 ` Eric Sunshine
2014-11-20 15:25 ` [PATCH 5/7] parse_color: support 24-bit RGB values Jeff King
2014-11-20 19:44 ` Junio C Hamano
2014-11-20 20:10 ` Jeff King
2014-11-20 20:25 ` Junio C Hamano [this message]
2014-11-20 15:25 ` [PATCH 6/7] parse_color: recognize "no$foo" to clear the $foo attribute Jeff King
2014-11-20 19:46 ` Junio C Hamano
2014-11-20 15:29 ` [PATCH 7/7] diff-highlight: allow configurable colors Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8uj539hi.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bakers@canbytel$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox