From: Junio C Hamano <gitster@pobox•com>
To: Pat Thoyts <patthoyts@users•sourceforge.net>
Cc: git@vger•kernel.org, pb158 <pb158@tlen•pl>
Subject: Re: [PATCH] git-gui: add configurable tab size to the diff view git-gui - why not added to git-gui ?
Date: Fri, 19 Sep 2014 10:02:23 -0700 [thread overview]
Message-ID: <xmqq8ulfo868.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqd2aro8fx.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Fri, 19 Sep 2014 09:56:34 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> I do not use git-gui, and I do not speak very good tcl/tk either, so
> I won't comment on the patch itself (Cc'ed its maintainer Pat), but
> thanks for trying to relay, anyway.
>
>> ----------------------
>>
>> For Tk 8.5 the "wordprocessor" mode allows us to get a bit fancy for merge
>> diffs and intend the tabs by one to compensate for the additional diff
>> marker at the line start.
>>
>> The code is heavily based on how gitk handles tabs.
>>
>> Signed-off-by: Michael Lutz <michi@xxxxxxxxxxxxxx>
>
> With this, the author refuses to be contacted if/when any question
> arises wrt the provenance of the patch, which is not a usable form
> of a sign-off. When you relay a change from somebody else who
> claims that he has rights to contribute the change to the project,
> and you have the rights to relay that change to the project, please
> also add your own sign-off.
Heh, I spoke too fast. The original is at $gmane/190576 [*1*] and
the butchering of the address is only due to the the spinics list
archive pb158 grabbed his or her copy from.
So we don't need any forwarder's sign-off. As long as the change is
acceptable (I have no opinion on it), the original can be directly
applied.
[References]
*1* http://article.gmane.org/gmane.comp.version-control.git/190576/raw
next prev parent reply other threads:[~2014-09-19 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 14:33 [PATCH] git-gui: add configurable tab size to the diff view git-gui - why not added to git-gui ? pb158
2014-09-19 16:56 ` Junio C Hamano
2014-09-19 17:02 ` Junio C Hamano [this message]
2014-09-19 17:44 ` pb158
2014-09-19 18:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8ulfo868.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=patthoyts@users$(echo .)sourceforge.net \
--cc=pb158@tlen$(echo .)pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox