From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: David Kastrup <dak@gnu•org>, git@vger•kernel.org
Subject: Re: [PATCH v2] cache_tree_find(): remove redundant checks
Date: Tue, 04 Mar 2014 13:05:59 -0800 [thread overview]
Message-ID: <xmqq8uspk72g.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1393921868-4382-1-git-send-email-mhagger@alum.mit.edu> (Michael Haggerty's message of "Tue, 4 Mar 2014 09:31:08 +0100")
Michael Haggerty <mhagger@alum•mit.edu> writes:
> while (*path) {
> - const char *slash;
> struct cache_tree_sub *sub;
> + const char *slash = strchr(path, '/');
>
> - slash = strchr(path, '/');
> if (!slash)
> slash = path + strlen(path);
Isn't the above a strchrnul()?
Combining a freestanding decl with intializer assignment to lose one
line is sort of cheating on the line count, but replacing the three
lines with a single strchrnul() would be a real code reduction ;-)
> - /* between path and slash is the name of the
> - * subtree to look for.
> + /*
> + * Between path and slash is the name of the subtree
> + * to look for.
> */
> sub = find_subtree(it, path, slash - path, 0);
> if (!sub)
> return NULL;
> it = sub->cache_tree;
> - if (slash)
> - while (*slash && *slash == '/')
> - slash++;
> - if (!slash || !*slash)
> - return it; /* prefix ended with slashes */
> path = slash;
> + while (*path == '/')
> + path++;
> }
> return it;
> }
next prev parent reply other threads:[~2014-03-04 21:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 8:31 [PATCH v2] cache_tree_find(): remove redundant checks Michael Haggerty
2014-03-04 9:40 ` David Kastrup
2014-03-04 10:22 ` Michael Haggerty
2014-03-04 10:34 ` David Kastrup
2014-03-04 21:05 ` Junio C Hamano [this message]
2014-03-04 22:24 ` Michael Haggerty
2014-03-04 23:18 ` Junio C Hamano
2014-03-05 17:57 ` Junio C Hamano
2014-03-05 4:38 ` David Kastrup
2014-03-05 18:40 ` Junio C Hamano
2014-03-04 21:11 ` [microproject idea] Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8uspk72g.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dak@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox