Subject: Re: [PATCH 1/9] t/unit-tests: adapt lib-reftable{c,h} helper functions to clar

From: Junio C Hamano <[email-masked]>
Date: Mon, 28 Apr 2025 16:27:03 -0700

Seyi Kuforiji <[email-masked]> writes:

> Helper functions defined in `t/unit-tests/lib-reftable.{c,h}` are
> required for the reftable-related test files to run efficeintly. In the
> current implementation these functions are designed to conform with our
> homegrown unit-testing structure. So in other to convert the reftable
> test files, there is need for a clar specific implementation of these
> helper functions.
>
> type cast `for (size_t i = 0; i < (size_t)stats->ref_stats.blocks; i++)`
> Adapt functions in lib-reftable.{c,h} to use clar. These functions
> conform with the clar testing framework and become available for all
> reftable-related test files implemented using the clar testing
> framework, which requires them. This will be used by subsequent commits.
>
> Signed-off-by: Seyi Kuforiji <[email-masked]>
> ---
>  Makefile                    |  4 ++--
>  t/meson.build               |  4 ++--
>  t/unit-tests/lib-reftable.c | 26 +++++++++++++-------------
>  t/unit-tests/lib-reftable.h |  6 +++---
>  4 files changed, 20 insertions(+), 20 deletions(-)

With this step (and nothing else, as this is the first patch in the
series) applied to 'master', I see tons of these errors:

    CC t/unit-tests/t-reftable-merged.o
t/unit-tests/t-reftable-merged.c: In function 'merged_table_from_records':
t/unit-tests/t-reftable-merged.c:37:17: error: implicit declaration of function 't_reftable_write_to_buf'; did you mean 'cl_reftable_write_to_buf'? [-Wimplicit-function-declaration]
   37 |                 t_reftable_write_to_buf(&buf[i], refs[i], sizes[i], NULL, 0, &opts);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
      |                 cl_reftable_write_to_buf