Subject: Re: [PATCH 1/2] commit-graph.c: remove temporary graph layers on exit

From: Junio C Hamano <[email-masked]>
Date: Fri, 07 Jun 2024 09:33:56 -0700

Taylor Blau <[email-masked]> writes:

> @@ -2133,8 +2132,6 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx)
>  		char *final_graph_name;
>  		int result;
>  
> -		close(fd);
> -
>  		if (!chainf) {
>  			error(_("unable to open commit-graph chain file"));
>  			return -1;
> @@ -2169,7 +2166,7 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx)
>  		free(ctx->commit_graph_filenames_after[ctx->num_commit_graphs_after - 1]);
>  		ctx->commit_graph_filenames_after[ctx->num_commit_graphs_after - 1] = final_graph_name;
>  
> -		result = rename(ctx->graph_name, final_graph_name);
> +		result = rename_tempfile(&graph_layer, final_graph_name);

Before this rename, after the close(fd) we saw in the previous hunk,
there is one early error return when we fail to rename the base
graph file.  Do we need to do anything there, or an unfinished
tempfile getting removed at the process termination is sufficient
for cleaning up the mess?

Other than that, this looked quite straight-forward.

Thanks.